Merged
Conversation
[ upstream commit 90725f7 ] The following commit removed the unused node config definition `MCAST_GROUP_OUTER_V4_MAP`. commit cce6a96 Author: Timo Beckers <timo@isovalent.com> Date: Thu Feb 6 15:42:49 2025 +0100 multicast: remove unused MCAST_GROUP_OUTER_V4_MAP node define However, the actual NodeDefines map was not initialized. Ensure the defines.Map is initialized when enabling multicast. Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit bf0dca5 ] [ backporter's notes: it looks like that the gke-create-esp-rule action did not exist in v1.18. Hence, I've applied the same changes directly to the corresponding step of the Conformance GKE workflow. ] Previously, ESP rule was too broad and automation was deleting firewall rule. Let's switch to only allowing ESP traffic between nodes. Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Member
Author
|
/ci-gke |
Member
Author
|
/test |
Member
Author
|
The Conformance GKE workflow looks in a bad shape, but the same also applies on main (e.g., latest scheduled run), so I assume it being unrelated to this specific changes. Marking ready for review. |
nebril
approved these changes
Jan 19, 2026
ldelossa
approved these changes
Jan 19, 2026
ldelossa
approved these changes
Jan 19, 2026
3 tasks
marseel
approved these changes
Jan 20, 2026
joestringer
reviewed
Jan 20, 2026
Member
joestringer
left a comment
There was a problem hiding this comment.
LGTM for @cilium/github-sec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs skipped due to conflicts:
Once this PR is merged, a GitHub action will update the labels of these PRs: