Skip to content

multicast: do not assign to nil node config map#40859

Merged
ldelossa merged 1 commit intomainfrom
ldelossa/fix-multicast
Aug 6, 2025
Merged

multicast: do not assign to nil node config map#40859
ldelossa merged 1 commit intomainfrom
ldelossa/fix-multicast

Conversation

@ldelossa
Copy link
Copy Markdown
Contributor

@ldelossa ldelossa commented Aug 1, 2025

See commit message for details

Fixes: #40830

multicast: fix nil assignment to node configuration cell.Out map

@ldelossa ldelossa requested a review from a team as a code owner August 1, 2025 00:53
@ldelossa ldelossa requested a review from gentoo-root August 1, 2025 00:53
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 1, 2025
@ldelossa ldelossa added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/multicast Impacts the Multicast feature. kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. labels Aug 1, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 1, 2025
@ldelossa
Copy link
Copy Markdown
Contributor Author

ldelossa commented Aug 1, 2025

/test

@ldelossa ldelossa force-pushed the ldelossa/fix-multicast branch from 3c9708a to d44293e Compare August 1, 2025 01:10
@ldelossa ldelossa changed the title multicast: do assign to nil node config map multicast: do not assign to nil node config map Aug 1, 2025
@ldelossa
Copy link
Copy Markdown
Contributor Author

ldelossa commented Aug 1, 2025

/test

The following commit removed the unused node config definition
`MCAST_GROUP_OUTER_V4_MAP`.

commit cce6a96
Author: Timo Beckers <timo@isovalent.com>
Date:   Thu Feb 6 15:42:49 2025 +0100

    multicast: remove unused MCAST_GROUP_OUTER_V4_MAP node define

However, the actual NodeDefines map was not initialized.

Ensure the defines.Map is initialized when enabling multicast.

Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
@ldelossa ldelossa force-pushed the ldelossa/fix-multicast branch from d44293e to 960b782 Compare August 1, 2025 13:32
@ldelossa
Copy link
Copy Markdown
Contributor Author

ldelossa commented Aug 1, 2025

/test

@ldelossa ldelossa enabled auto-merge August 1, 2025 14:21
@ldelossa ldelossa added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 90725f7 Aug 6, 2025
306 of 307 checks passed
@ldelossa ldelossa deleted the ldelossa/fix-multicast branch August 6, 2025 17:34
@julianwiedmann julianwiedmann added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/bug This PR fixes an issue in a previous release of Cilium. labels Sep 4, 2025
@giorio94 giorio94 added the needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch label Jan 19, 2026
@giorio94 giorio94 mentioned this pull request Jan 19, 2026
2 tasks
@giorio94 giorio94 added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Jan 19, 2026
@github-actions github-actions bot added backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Jan 20, 2026
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/multicast Impacts the Multicast feature. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

Failure to upgrade to cilium 1.18 when multicast group is enabled

5 participants