bpf: Fix marker to skip nodeport when punting to proxy#43069
Merged
Conversation
Member
Author
|
/test |
julianwiedmann
approved these changes
Dec 2, 2025
Member
julianwiedmann
left a comment
There was a problem hiding this comment.
A BPF test for this particular path could be similar as the existing XDP test for a local backend (
cilium/bpf/tests/xdp_nodeport_lb4_nat_lb.c
Line 171 in c625631
Member
Author
Yeap agree, I likely won't get to it before LPC, but will look into this afterwards. |
mhofstetter
approved these changes
Dec 18, 2025
Julian spotted that setting ctx_skip_nodeport_set(ctx) is not having the desired effect for the case when there is XDP used on the node. The ctx_skip_nodeport_set() marker is not transferred to the skb and as a result the service lookup would happen twice instead of just in the XDP layer resulting in higher per-packet cost. The latter lookup in the tcx layer for such packets is unnecessary. Therefore, use the correct ctx_set_xfer(ctx, XFER_PKT_NO_SVC). Reported-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
8c17cd3 to
a2016fb
Compare
1343c59 to
d91a30b
Compare
Add a test where the backend is local with the service L7 proxy delegate. We expect the service to be passed up the stack unmodified. XFER_PKT_NO_SVC is set to skip tcx service handling a second time. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
d91a30b to
736edd0
Compare
Add a test where the backend is remote with the service L7 proxy delegate. We expect the service to be NATed and sent out the node. XFER_PKT_NO_SVC is /not/ set in this case given the backend is not part of the local endpoint map. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
100be2c to
a6a4a97
Compare
Member
Author
|
/test |
Member
|
👋 Backporter here. I've encountered significant conflicts when trying to backport this PR to v1.18, as the target hunks of the first commit seem to have diverged significantly between the two branches. Marking as |
Member
Author
Yep, I'll take care of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit msg)