envoy: Sync deny policies for Ingress policy enforcement#39736
Merged
joestringer merged 3 commits intocilium:mainfrom Jun 20, 2025
Merged
envoy: Sync deny policies for Ingress policy enforcement#39736joestringer merged 3 commits intocilium:mainfrom
joestringer merged 3 commits intocilium:mainfrom
Conversation
3499f8d to
2832d8d
Compare
Member
Author
|
/test |
doniacld
approved these changes
May 28, 2025
asauber
approved these changes
May 29, 2025
2832d8d to
d8388fe
Compare
Member
Author
|
rebased to fix conflicts |
Member
Author
|
/test |
Member
Author
|
/test |
d8388fe to
b823c32
Compare
sayboras
approved these changes
Jun 18, 2025
Avoid callers in other packages having to make nil checks by exporting GetDeny(). Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Now that endpoint policies with east/west Ingress are enforced completely in Envoy we must sync the full deny policy to Envoy, as we can not rely on the bpf datapath doing it prior to Envoy. Fixes: cilium#39730 Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Add unit test cases with deny policies. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
b823c32 to
fee09dc
Compare
Member
Author
|
Rebased to hopefully unstuck the auto-merge, which may have been confused by some skipped but required workflows. |
Member
Author
|
/test |
Member
As per the github ui, auto merge is not enabled due to the below reason. I am guessing Donia is no longer part of sig-policy.
|
bimmlerd
approved these changes
Jun 20, 2025
1 task
julianwiedmann
added a commit
that referenced
this pull request
Oct 13, 2025
Looking at the failures [0] when running these tests against v1.16, it seems like we might be missing #39736. Rather than backporting more & more fixes into old stable releases, roll back the testing to the old behavior before #39667 was merged. Note that the `v1.17.0` is just a guess, we might actually require a more recent patch version of v1.17. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
Looking at the failures [0] when running these tests against v1.16, it seems like we might be missing #39736. Rather than backporting more & more fixes into old stable releases, roll back the testing to the old behavior before #39667 was merged. Note that the `v1.17.0` is just a guess, we might actually require a more recent patch version of v1.17. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
aditighag
pushed a commit
to aditighag/cilium
that referenced
this pull request
Oct 14, 2025
Looking at the failures [0] when running these tests against v1.16, it seems like we might be missing cilium#39736. Rather than backporting more & more fixes into old stable releases, roll back the testing to the old behavior before cilium#39667 was merged. Note that the `v1.17.0` is just a guess, we might actually require a more recent patch version of v1.17. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that endpoint policies with east/west Ingress are enforced completely in Envoy we must sync the full deny policy to Envoy, as we can not rely on the bpf datapath doing it prior to Envoy.
Fixes: #39730