Skip to content

cilium-cli: IPv6 connectivity tests for PodToIngress#39667

Merged
joestringer merged 1 commit intomainfrom
pr/max/ipv6-tests-3
Aug 27, 2025
Merged

cilium-cli: IPv6 connectivity tests for PodToIngress#39667
joestringer merged 1 commit intomainfrom
pr/max/ipv6-tests-3

Conversation

@gentoo-root
Copy link
Copy Markdown
Contributor

Test both IPv4 and IPv6 explicitly. ForEachIPFamily ensures testing those address families that are supported in the cluster.

Fixes: #37137

@gentoo-root gentoo-root added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels May 21, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels May 21, 2025
@gentoo-root
Copy link
Copy Markdown
Contributor Author

/test

@julianwiedmann julianwiedmann added the feature/ipv6 Relates to IPv6 protocol support label May 22, 2025
@gentoo-root gentoo-root force-pushed the pr/max/ipv6-tests-3 branch from d300762 to 18bd490 Compare May 22, 2025 22:11
@gentoo-root
Copy link
Copy Markdown
Contributor Author

/test

@gentoo-root
Copy link
Copy Markdown
Contributor Author

Blocked by: #39730

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jun 26, 2025
@gentoo-root gentoo-root added the pinned These issues are not marked stale by our issue bot. label Jun 26, 2025
@gentoo-root gentoo-root force-pushed the pr/max/ipv6-tests-3 branch from eca31ef to efd43fe Compare June 26, 2025 16:29
@gentoo-root
Copy link
Copy Markdown
Contributor Author

/test

@gentoo-root gentoo-root removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jun 26, 2025
@gentoo-root
Copy link
Copy Markdown
Contributor Author

Weird, I'm still getting:

Test [pod-to-ingress-service-deny-backend-service]:
  🟥 pod-to-ingress-service-deny-backend-service/pod-to-ingress-service:curl-ipv4-0: cilium-test-4/client-645b68dcf7-wqqlt (10.244.1.146) -> cilium-test-4/cilium-ingress-same-node (10.96.168.153:80): command "curl --silent --fail --show-error --connect-timeout 2 --max-time 10 -4 -w %{local_ip}:%{local_port} -> %{remote_ip}:%{remote_port} = %{response_code}\n --output /dev/null [http://10.96.168.153:80](http://10.96.168.153/)" succeeded while it should have failed: 10.244.1.146:52346 -> 10.96.168.153:80 = 200

even after #39730 has been fixed (the steps to reproduce no longer work).

@gentoo-root
Copy link
Copy Markdown
Contributor Author

/test

@gentoo-root
Copy link
Copy Markdown
Contributor Author

/test

@gentoo-root gentoo-root marked this pull request as ready for review August 18, 2025 11:42
@gentoo-root gentoo-root requested review from a team as code owners August 18, 2025 11:42
Copy link
Copy Markdown
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 nice, thanks!

One suggestion to improve readability by using ptr.To(...) functionalty. But I already approve - under the assumption that you're going to refactor this.

Copy link
Copy Markdown
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(form re-submission issue 😄 )

@gentoo-root gentoo-root added needs-backport/1.16 needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Sep 26, 2025
@joamaki joamaki mentioned this pull request Oct 1, 2025
14 tasks
zocimek added a commit to zocimek/home-ops that referenced this pull request Oct 1, 2025
… ) (#222)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[aqua:cilium/cilium-cli](https://redirect.github.com/cilium/cilium-cli)
| patch | `0.18.6` -> `0.18.7` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>cilium/cilium-cli (aqua:cilium/cilium-cli)</summary>

###
[`v0.18.7`](https://redirect.github.com/cilium/cilium-cli/releases/tag/v0.18.7)

[Compare
Source](https://redirect.github.com/cilium/cilium-cli/compare/v0.18.6...v0.18.7)

#### What's Changed

## Summary of Changes

**Minor Changes:**

- clustermesh: cli: accept more than one service IPs (excluding when
connecting to NodePort Services) when connecting to remote
clustermesh-apiserver
([cilium/cilium#41253](https://redirect.github.com/cilium/cilium/issues/41253),
[@&#8203;MrFreezeex](https://redirect.github.com/MrFreezeex))
- clustermesh: cli: add support for dict for helm values
`clustermesh.config.clusters`
([cilium/cilium#40879](https://redirect.github.com/cilium/cilium/issues/40879),
[@&#8203;MrFreezeex](https://redirect.github.com/MrFreezeex))
- clustermesh: cli: support outputting `clustermesh.config.clusters` to
the new dict format if the cluster is running Cilium >= 1.20
([cilium/cilium#40959](https://redirect.github.com/cilium/cilium/issues/40959),
[@&#8203;MrFreezeex](https://redirect.github.com/MrFreezeex))

**Bugfixes:**

- Add l7 proxy check to policy-local-cluster-egress connectivity test
([cilium/cilium#40797](https://redirect.github.com/cilium/cilium/issues/40797),
[@&#8203;camrynl](https://redirect.github.com/camrynl))
- cilium-cli: also restart cilium-operator pods on config changes
([cilium/cilium#41067](https://redirect.github.com/cilium/cilium/issues/41067),
[@&#8203;aanm](https://redirect.github.com/aanm))

**CI Changes:**

- Allow Egress Gateway connectivity tests to run concurrently
([cilium/cilium#40980](https://redirect.github.com/cilium/cilium/issues/40980),
[@&#8203;tommyp1ckles](https://redirect.github.com/tommyp1ckles))
- cilium-cli: connectivity tests: Ignore some logs in error log check
([cilium/cilium#40690](https://redirect.github.com/cilium/cilium/issues/40690),
[@&#8203;jrife](https://redirect.github.com/jrife))
- cilium-cli: IPv6 connectivity tests for PodToIngress
([cilium/cilium#39667](https://redirect.github.com/cilium/cilium/issues/39667),
[@&#8203;gentoo-root](https://redirect.github.com/gentoo-root))

**Misc Changes:**

- chore(deps): update all-dependencies (main)
([cilium/cilium#40893](https://redirect.github.com/cilium/cilium/issues/40893),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update all-dependencies (main)
([cilium/cilium#41046](https://redirect.github.com/cilium/cilium/issues/41046),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update all-dependencies (main)
([cilium/cilium#41340](https://redirect.github.com/cilium/cilium/issues/41340),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update all-dependencies (main)
([cilium/cilium#41433](https://redirect.github.com/cilium/cilium/issues/41433),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update docker.io/library/golang:1.25.0 docker digest to
[`5502b0e`](https://redirect.github.com/cilium/cilium-cli/commit/5502b0e)
(main)
([cilium/cilium#41343](https://redirect.github.com/cilium/cilium/issues/41343),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- chore(deps): update go to v1.24.6 (main)
([cilium/cilium#40992](https://redirect.github.com/cilium/cilium/issues/40992),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- cilium-cli: Optimized feature detection by running cluster-wide checks
once
([cilium/cilium#40715](https://redirect.github.com/cilium/cilium/issues/40715),
[@&#8203;HadrienPatte](https://redirect.github.com/HadrienPatte))
- Include bgp remote peer capabilities in the sysdump
([cilium/cilium#40719](https://redirect.github.com/cilium/cilium/issues/40719),
[@&#8203;liyihuang](https://redirect.github.com/liyihuang))
- Update all-dependencies (main)
([cilium/cilium#41175](https://redirect.github.com/cilium/cilium/issues/41175),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- Update docker.io/alpine/socat:1.8.0.3 Docker digest to
[`29d0f24`](https://redirect.github.com/cilium/cilium-cli/commit/29d0f24)
(main)
([cilium/cilium#41204](https://redirect.github.com/cilium/cilium/issues/41204),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- Update Go to v1.25.0 (main)
([cilium/cilium#41209](https://redirect.github.com/cilium/cilium/issues/41209),
[@&#8203;cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot])
- Update stable release to v0.18.6 by
[@&#8203;tklauser](https://redirect.github.com/tklauser) in
[#&#8203;3075](https://redirect.github.com/cilium/cilium-cli/pull/3075)
- chore(deps): update golangci/golangci-lint docker tag to v2.3.1 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3076](https://redirect.github.com/cilium/cilium-cli/pull/3076)
- chore(deps): update golang docker tag to v1.24.6 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3079](https://redirect.github.com/cilium/cilium-cli/pull/3079)
- chore(deps): update gcr.io/distroless/static:latest docker digest to
[`2e114d2`](https://redirect.github.com/cilium/cilium-cli/commit/2e114d2)
by [@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3077](https://redirect.github.com/cilium/cilium-cli/pull/3077)
- chore(deps): update docker/login-action action to v3.5.0 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3078](https://redirect.github.com/cilium/cilium-cli/pull/3078)
- chore(deps): update go to v1.24.6 (patch) by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3080](https://redirect.github.com/cilium/cilium-cli/pull/3080)
- chore(deps): update actions/checkout action to v5 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3082](https://redirect.github.com/cilium/cilium-cli/pull/3082)
- chore(deps): update golangci/golangci-lint docker tag to v2.4.0 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3086](https://redirect.github.com/cilium/cilium-cli/pull/3086)
- chore(deps): update golang docker tag to v1.25.0 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3085](https://redirect.github.com/cilium/cilium-cli/pull/3085)
- chore(deps): update go to v1.25.0 (minor) by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3088](https://redirect.github.com/cilium/cilium-cli/pull/3088)
- chore(deps): update dependency cilium/cilium to v1.18.1 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3089](https://redirect.github.com/cilium/cilium-cli/pull/3089)
- chore(deps): update dependency kubernetes-sigs/kind to v0.30.0 by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3091](https://redirect.github.com/cilium/cilium-cli/pull/3091)
- chore(deps): update golang-images - autoclosed by
[@&#8203;renovate](https://redirect.github.com/renovate)\[bot] in
[#&#8203;3090](https://redirect.github.com/cilium/cilium-cli/pull/3090)
- Prepare for v0.18.7 release by
[@&#8203;michi-covalent](https://redirect.github.com/michi-covalent) in
[#&#8203;3092](https://redirect.github.com/cilium/cilium-cli/pull/3092)

**Full Changelog**:
<cilium/cilium-cli@v0.18.6...v0.18.7>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45NS4wIiwidXBkYXRlZEluVmVyIjoiNDEuMTMyLjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInR5cGUvcGF0Y2giXX0=-->

Co-authored-by: zocimek-renovate[bot] <134739422+zocimek-renovate[bot]@users.noreply.github.com>
Co-authored-by: Łukasz Pospiech <zocimek@users.noreply.github.com>
@joamaki joamaki mentioned this pull request Oct 2, 2025
3 tasks
@joamaki joamaki added the backport/author The backport will be carried out by the author of the PR. label Oct 2, 2025
@joamaki
Copy link
Copy Markdown
Contributor

joamaki commented Oct 2, 2025

Skipped in backports and marked as backport/author as this is making changes to cilium-cli/... which does not exist in the released branches. Please backport manually if still necessary.

@gentoo-root
Copy link
Copy Markdown
Contributor Author

as this is making changes to cilium-cli/...

@joamaki, these should be dropped; only the changes from other directories are to be backported. It's needed to fix #41577

@joamaki
Copy link
Copy Markdown
Contributor

joamaki commented Oct 3, 2025

as this is making changes to cilium-cli/...

@joamaki, these should be dropped; only the changes from other directories are to be backported. It's needed to fix #41577

I've included this now into both v1.17 and v1.18 backports with the cilium-cli changes dropped.

@joamaki joamaki removed the backport/author The backport will be carried out by the author of the PR. label Oct 3, 2025
@gentoo-root
Copy link
Copy Markdown
Contributor Author

Thank you!

@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. labels Oct 4, 2025
@julianwiedmann julianwiedmann removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Oct 6, 2025
@tklauser tklauser mentioned this pull request Oct 7, 2025
2 tasks
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 labels Oct 9, 2025
julianwiedmann added a commit that referenced this pull request Oct 13, 2025
Looking at the failures [0] when running these tests against v1.16, it
seems like we might be missing #39736.

Rather than backporting more & more fixes into old stable releases, roll
back the testing to the old behavior before
#39667 was merged.

Note that the `v1.17.0` is just a guess, we might actually require a more
recent patch version of v1.17.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Copy Markdown
Member

@gentoo-root 👋 nice to see this land! What's your gut feeling, will these tests currently pass on Cilium v1.15 (oldest release we test in CI, when downgrading from the v1.16 branch). Asking as it seems to require #39736, which didn't get the full-blown backport treatment so far.

Otherwise we might want to add a versioncheck?

Doing so here: #42148

github-merge-queue bot pushed a commit that referenced this pull request Oct 14, 2025
Looking at the failures [0] when running these tests against v1.16, it
seems like we might be missing #39736.

Rather than backporting more & more fixes into old stable releases, roll
back the testing to the old behavior before
#39667 was merged.

Note that the `v1.17.0` is just a guess, we might actually require a more
recent patch version of v1.17.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
aditighag pushed a commit to aditighag/cilium that referenced this pull request Oct 14, 2025
Looking at the failures [0] when running these tests against v1.16, it
seems like we might be missing cilium#39736.

Rather than backporting more & more fixes into old stable releases, roll
back the testing to the old behavior before
cilium#39667 was merged.

Note that the `v1.17.0` is just a guess, we might actually require a more
recent patch version of v1.17.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/CI Continuous Integration testing issue or flake backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary feature/ipv6 Relates to IPv6 protocol support feature/k8s-ingress pinned These issues are not marked stale by our issue bot. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

Add explicit IPv6 testing to PodToIngress cilium-cli connectivity test scenario

8 participants