Skip to content

bpf/complexity-tests: fix ENABLE_LOCAL_REDIRECT_POLICY#35099

Merged
julianwiedmann merged 1 commit intocilium:mainfrom
ysksuzuki:fix-complex-test-lrp
Sep 30, 2024
Merged

bpf/complexity-tests: fix ENABLE_LOCAL_REDIRECT_POLICY#35099
julianwiedmann merged 1 commit intocilium:mainfrom
ysksuzuki:fix-complex-test-lrp

Conversation

@ysksuzuki
Copy link
Copy Markdown
Member

@ysksuzuki ysksuzuki commented Sep 30, 2024

8fcbc65 added ENABLE_LOCAL_REDIRECT_POLICY to the complexity-test configuration, but it didn't pass a value. We should declare as -DENABLE_LOCAL_REDIRECT_POLICY=1 because the is_defined() helper strictly requires 0 or 1 as value.

follow up of #35016

@ysksuzuki
bpf/complexity-tests: fix ENABLE_LOCAL_REDIRECT_POLICY
a41a266 
8fcbc65 added ENABLE_LOCAL_REDIRECT_POLICY
to the complexity-test configuration, but it didn't pass a value.
We should declare as `-DENABLE_LOCAL_REDIRECT_POLICY=1` because
the is_defined() helper strictly requires 0 or 1 as value.
This commit fixes it.

Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 30, 2024
@ysksuzuki ysksuzuki added release-note/ci This PR makes changes to the CI. area/lrp Impacts Local Redirect Policy. backport/author The backport will be carried out by the author of the PR. needs-backport/1.16 labels Sep 30, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 30, 2024
@ysksuzuki
Copy link
Copy Markdown
Member Author

ysksuzuki commented Sep 30, 2024

/test

@ysksuzuki ysksuzuki mentioned this pull request Sep 30, 2024
Merged
@ysksuzuki ysksuzuki marked this pull request as ready for review September 30, 2024 07:40
@ysksuzuki ysksuzuki requested a review from a team as a code owner September 30, 2024 07:40
julianwiedmann
julianwiedmann approved these changes Sep 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@julianwiedmann julianwiedmann added the area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Sep 30, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Sep 30, 2024
Merged via the queue into cilium:main with commit 60f91ca Sep 30, 2024
@ysksuzuki ysksuzuki mentioned this pull request Oct 1, 2024
Merged
@ysksuzuki ysksuzuki added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed needs-backport/1.16 labels Oct 1, 2024
julianwiedmann added a commit that referenced this pull request Sep 1, 2025
@julianwiedmann
bpf/complexity-tests: test ENABLE_LOCAL_REDIRECT_POLICY on 5.4 kernel
8638c79 
Extend the LRP load-testing that was introduced with
#35016 and
#35099, so that the 5.4 kernel is
also covered.

This helps to reproduce the bug reported in
#40457.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Sep 1, 2025
@julianwiedmann
bpf/complexity-tests: test ENABLE_LOCAL_REDIRECT_POLICY on 5.4 kernel
8a4db90 
Extend the LRP load-testing that was introduced with
#35016 and
#35099, so that the 5.4 kernel is
also covered.

This helps to reproduce the bug reported in
#40457.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann added a commit that referenced this pull request Sep 1, 2025
@julianwiedmann
bpf/complexity-tests: test ENABLE_LOCAL_REDIRECT_POLICY on 5.4 kernel
7558d48 
[ upstream commit 8a4db90 ]

Extend the LRP load-testing that was introduced with
#35016 and
#35099, so that the 5.4 kernel is
also covered.

This helps to reproduce the bug reported in
#40457.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Sep 2, 2025
@julianwiedmann
bpf/complexity-tests: test ENABLE_LOCAL_REDIRECT_POLICY on 5.4 kernel
efa23d4 
[ upstream commit 8a4db90 ]

Extend the LRP load-testing that was introduced with
#35016 and
#35099, so that the 5.4 kernel is
also covered.

This helps to reproduce the bug reported in
#40457.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julianwiedmann julianwiedmann julianwiedmann approved these changes

@YutaroHayakawa YutaroHayakawa Awaiting requested review from YutaroHayakawa YutaroHayakawa is a code owner automatically assigned from cilium/sig-datapath

Assignees

No one assigned

Labels

area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/lrp Impacts Local Redirect Policy. backport/author The backport will be carried out by the author of the PR. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ysksuzuki @julianwiedmann