bpf/complexity-tests: Add ENABLE_LOCAL_REDIRECT_POLICY#35016
bpf/complexity-tests: Add ENABLE_LOCAL_REDIRECT_POLICY#35016tklauser merged 1 commit intocilium:mainfrom
Conversation
|
/test |
The datapath has `#ifdef`s for this define in its service translation path for both socket LB and per packet LB, so we should add it to the complexity tests. Note that skipRedirectFromBackend configuration requires SO_NETNS_COOKIE feature available in Linux kernel version >= 5.8. So this commit adds ENABLE_LOCAL_REDIRECT_POLICY to the kernel version >= 5.8. Fixes: cilium#34240 Signed-off-by: Yusuke Suzuki <yusuke.suzuki@isovalent.com>
7110291 to
f220357
Compare
|
/test |
| -DENABLE_SCTP=1 | ||
| -DENABLE_IPSEC=1 | ||
| -DEVENTS_MAP_RATE_LIMIT_PER_SECOND=1000 | ||
| -DENABLE_LOCAL_REDIRECT_POLICY |
There was a problem hiding this comment.
I think that we've been declaring these as -DENABLE_LOCAL_REDIRECT_POLICY=1, because the is_defined() helper strictly requires 0 or 1 as value.
There was a problem hiding this comment.
Oh, I will fix it. Thanks for the comment!
@ysksuzuki 👋 coming from #41449 - do you remember why we didn't add the test coverage for |
|
@julianwiedmann As far as I remember this was part of the LRP-to-stable promotion. We required skipRedirectFromBackend for the stable profile, so I think kernels that didn’t support it were excluded from test coverage. |
The datapath has
#ifdefs for this define in its service translation path for both socket LB and per packet LB, so we should add it to the complexity tests.Note that skipRedirectFromBackend configuration requires SO_NETNS_COOKIE feature available in Linux kernel version >= 5.8. So this commit adds ENABLE_LOCAL_REDIRECT_POLICY to the kernel version >= 5.8.
Fixes: #34240