Skip to content

golang: Enable type alias again for go 1.23#34988

Closed
sayboras wants to merge 2 commits intocilium:mainfrom
sayboras:pr/tammach/enable-type-alias
Closed

golang: Enable type alias again for go 1.23#34988
sayboras wants to merge 2 commits intocilium:mainfrom
sayboras:pr/tammach/enable-type-alias

Conversation

@sayboras
Copy link
Copy Markdown
Member

@sayboras sayboras commented Sep 20, 2024

All files are re-generated again as there is a change in generation tools.

Relates: kubernetes/kubernetes#127271
Relates: cilium/deepequal-gen#6
Relates: kubernetes-sigs/controller-tools#1061
Relates: 1d9d51f

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 20, 2024
@sayboras sayboras added dont-merge/preview-only Only for preview or testing, don't merge it. release-note/misc This PR makes changes that have no direct user impact. labels Sep 20, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 20, 2024
@sayboras sayboras force-pushed the pr/tammach/enable-type-alias branch from 2f30ffe to a00d768 Compare September 20, 2024 15:00
@sayboras
Copy link
Copy Markdown
Member Author

/test

@sayboras sayboras changed the title golang: Enable type alias again for go 1.13 golang: Enable type alias again for go 1.23 Sep 20, 2024
@sayboras sayboras force-pushed the pr/tammach/enable-type-alias branch from a00d768 to d3b1793 Compare September 25, 2024 15:10
@sayboras
Copy link
Copy Markdown
Member Author

/test

@sayboras sayboras force-pushed the pr/tammach/enable-type-alias branch from d3b1793 to 237ae3f Compare September 26, 2024 02:55
sayboras added a commit that referenced this pull request Oct 2, 2024
This is to pick up the changes in cilium/deepequal-gen#7.
The main goal is to enable go 1.23 type alias again.

Relates: #34988
Relates: cilium/deepequal-gen#7

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/enable-type-alias branch from 237ae3f to 2b7f26c Compare October 2, 2024 11:17
sayboras added a commit that referenced this pull request Oct 2, 2024
This is to pick up the changes in cilium/deepequal-gen#7.
The main goal is to enable go 1.23 type alias again.

Relates: #34988
Relates: cilium/deepequal-gen#7

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/enable-type-alias branch 2 times, most recently from 6923557 to 15248bc Compare October 7, 2024 04:52
@sayboras sayboras force-pushed the pr/tammach/enable-type-alias branch from 15248bc to 0f04de0 Compare October 15, 2024 13:45
Signed-off-by: Tam Mach <tam.mach@cilium.io>
All files are re-generated again as there is change in generation tools.

Relates: kubernetes/kubernetes#127271
Relates: cilium/deepequal-gen#7
Relates: kubernetes-sigs/controller-tools#1061
Relates: 1d9d51f
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/enable-type-alias branch from 0f04de0 to 335af2f Compare October 15, 2024 13:56
@sayboras sayboras closed this Oct 15, 2024
@sayboras sayboras deleted the pr/tammach/enable-type-alias branch October 15, 2024 13:59
@sayboras
Copy link
Copy Markdown
Member Author

Closed in favor of #35406, so that the changes in GHA can be verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-merge/preview-only Only for preview or testing, don't merge it. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant