Add success/failure msg to vagrant start.sh#317
Merged
tgraf merged 1 commit intocilium:masterfrom Mar 17, 2017
Merged
Conversation
Member
|
Hey @danwent the PR looks great, however we can't accept it unless the commit is signed ( More info: https://github.com/cilium/cilium/blob/master/doc/contributing.md#developers-certificate-of-origin |
yoursanonymous
pushed a commit
to yoursanonymous/cilium
that referenced
this pull request
Jan 31, 2026
* re-write (cilium#1) * wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks,
When testing with Vagrant, I saw that the start.sh script would end with the following line regardless of whether Cilium successfully came up or not.
==> cilium-master: Waiting for Cilium daemon to come up...
Here's a small tweak to make the script print a success or error message.
Note: you can't tell from the diff, but this chunk of code is actually part of a larger block that writes this out as a file (cilium-master.sh), and then executes it. This is why the $cilium_started needs to be escaped. See http://stackoverflow.com/questions/2953646/how-to-declare-and-use-boolean-variables-in-shell-script for why that needs to be double-quoted in the first place.
git commit -sor since you want to sign this commitgit commit --amend -s).More info: https://github.com/cilium/cilium/blob/master/doc/contributing.md#developers-certificate-of-origin