Fix some errors from go code analyzers in docker-plugin#1
Merged
Conversation
1fe6ce3 to
661e588
Compare
Signed-off-by: André Martins <aanm90@gmail.com>
661e588 to
b72c418
Compare
tgraf
added a commit
that referenced
this pull request
Jan 12, 2016
Fix some errors from go code analyzers in docker-plugin
tgraf
pushed a commit
that referenced
this pull request
Jul 4, 2016
…ant box. root@noiro-ucs08:~/cilium-net/packer-scripts/ubuntu-14.04# ls -l *.box -rw-r--r-- 1 root root 364980917 Dec 29 15:31 ubuntu-1404-libvirt.box vagrant@ubuntu:~$ uname -a Linux ubuntu 4.1.0-rc4-custom #1 SMP Tue Dec 29 15:26:42 PST 2015 x86_64 x86_64 x86_64 GNU/Linux vagrant@ubuntu:~$
tgraf
added a commit
that referenced
this pull request
Jul 4, 2016
Fix some errors from go code analyzers in docker-plugin
tgraf
added a commit
that referenced
this pull request
Feb 4, 2019
When the allocation CIDR changes, the existing code errored out. When that happened on the first agent restart, all existing endpoints failed to restore due to failure to allocate the existing endpoint's IP address. The failure to restore would then in turn get all existing endpoints deleted. This is bad in two ways: 1. It causes all endpoints to be removed, causing the pods to restart 2. It does not allow the agent to ever come up again without intervention from the user. This commit solves problem #2 to allow nodes to recover automatically. It does not solve problem #1 yet and requires pods to restart. Solving problem #2 only makes sense once we have isolated all datapath aspects such as the DNS proxy and L7 proxies out of the agent as endpoint connetivity cannot be guaranteed if the agent cannot come up within a reasonable amount of time. Fixes: #6215 Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
added a commit
that referenced
this pull request
Feb 4, 2019
When the allocation CIDR changes, the existing code errored out. When that happened on the first agent restart, all existing endpoints failed to restore due to failure to allocate the existing endpoint's IP address. The failure to restore would then in turn get all existing endpoints deleted. This is bad in two ways: 1. It causes all endpoints to be removed, causing the pods to restart 2. It does not allow the agent to ever come up again without intervention from the user. This commit solves problem #2 to allow nodes to recover automatically. It does not solve problem #1 yet and requires pods to restart. Solving problem #2 only makes sense once we have isolated all datapath aspects such as the DNS proxy and L7 proxies out of the agent as endpoint connetivity cannot be guaranteed if the agent cannot come up within a reasonable amount of time. Fixes: #6215 Signed-off-by: Thomas Graf <thomas@cilium.io>
ianvernon
pushed a commit
that referenced
this pull request
Feb 4, 2019
[ upstream commit 0b3ed95 ] When the allocation CIDR changes, the existing code errored out. When that happened on the first agent restart, all existing endpoints failed to restore due to failure to allocate the existing endpoint's IP address. The failure to restore would then in turn get all existing endpoints deleted. This is bad in two ways: 1. It causes all endpoints to be removed, causing the pods to restart 2. It does not allow the agent to ever come up again without intervention from the user. This commit solves problem #2 to allow nodes to recover automatically. It does not solve problem #1 yet and requires pods to restart. Solving problem #2 only makes sense once we have isolated all datapath aspects such as the DNS proxy and L7 proxies out of the agent as endpoint connetivity cannot be guaranteed if the agent cannot come up within a reasonable amount of time. Fixes: #6215 Signed-off-by: Thomas Graf <thomas@cilium.io> Signed-off-by: Ian Vernon <ian@cilium.io>
ianvernon
pushed a commit
that referenced
this pull request
Feb 4, 2019
[ upstream commit 0b3ed95 ] When the allocation CIDR changes, the existing code errored out. When that happened on the first agent restart, all existing endpoints failed to restore due to failure to allocate the existing endpoint's IP address. The failure to restore would then in turn get all existing endpoints deleted. This is bad in two ways: 1. It causes all endpoints to be removed, causing the pods to restart 2. It does not allow the agent to ever come up again without intervention from the user. This commit solves problem #2 to allow nodes to recover automatically. It does not solve problem #1 yet and requires pods to restart. Solving problem #2 only makes sense once we have isolated all datapath aspects such as the DNS proxy and L7 proxies out of the agent as endpoint connetivity cannot be guaranteed if the agent cannot come up within a reasonable amount of time. Fixes: #6215 Signed-off-by: Thomas Graf <thomas@cilium.io> Signed-off-by: Ian Vernon <ian@cilium.io>
3 tasks
2 tasks
3 tasks
Closed
3 tasks
3 tasks
3 tasks
3 tasks
karina-ranadive
pushed a commit
to karina-ranadive/cilium
that referenced
this pull request
Jan 23, 2026
…mplementation-in-cilium Add Gateway API datapath walkthrough
3 tasks
3 tasks
yoursanonymous
pushed a commit
to yoursanonymous/cilium
that referenced
this pull request
Jan 31, 2026
fix: set illustration absolute in Hero
yoursanonymous
pushed a commit
to yoursanonymous/cilium
that referenced
this pull request
Jan 31, 2026
feat: add Blog search
yoursanonymous
pushed a commit
to yoursanonymous/cilium
that referenced
this pull request
Jan 31, 2026
* re-write (cilium#1) * wording
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
Closed
3 tasks
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: André Martins aanm90@gmail.com