Skip to content

Fix some errors from go code analyzers in docker-plugin#1

Merged
tgraf merged 1 commit intomasterfrom
fix-errors-go-code-analyzers
Jan 12, 2016
Merged

Fix some errors from go code analyzers in docker-plugin#1
tgraf merged 1 commit intomasterfrom
fix-errors-go-code-analyzers

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Jan 12, 2016

Signed-off-by: André Martins aanm90@gmail.com

@aanm aanm force-pushed the fix-errors-go-code-analyzers branch from 1fe6ce3 to 661e588 Compare January 12, 2016 20:31
Signed-off-by: André Martins <aanm90@gmail.com>
@aanm aanm force-pushed the fix-errors-go-code-analyzers branch from 661e588 to b72c418 Compare January 12, 2016 20:31
tgraf added a commit that referenced this pull request Jan 12, 2016
Fix some errors from go code analyzers in docker-plugin
@tgraf tgraf merged commit 097824c into master Jan 12, 2016
@tgraf tgraf deleted the fix-errors-go-code-analyzers branch January 12, 2016 23:52
tgraf pushed a commit that referenced this pull request Jul 4, 2016
…ant box.

root@noiro-ucs08:~/cilium-net/packer-scripts/ubuntu-14.04# ls -l *.box
-rw-r--r-- 1 root root 364980917 Dec 29 15:31 ubuntu-1404-libvirt.box

vagrant@ubuntu:~$ uname -a
Linux ubuntu 4.1.0-rc4-custom #1 SMP Tue Dec 29 15:26:42 PST 2015 x86_64 x86_64 x86_64 GNU/Linux
vagrant@ubuntu:~$
tgraf added a commit that referenced this pull request Jul 4, 2016
Fix some errors from go code analyzers in docker-plugin
tgraf added a commit that referenced this pull request Feb 4, 2019
When the allocation CIDR changes, the existing code errored out. When that
happened on the first agent restart, all existing endpoints failed to restore
due to failure to allocate the existing endpoint's IP address. The failure to
restore would then in turn get all existing endpoints deleted.

This is bad in two ways:

1. It causes all endpoints to be removed, causing the pods to restart
2. It does not allow the agent to ever come up again without intervention from
   the user.

This commit solves problem #2 to allow nodes to recover automatically. It does
not solve problem #1 yet and requires pods to restart.

Solving problem #2 only makes sense once we have isolated all datapath aspects
such as the DNS proxy and L7 proxies out of the agent as endpoint connetivity
cannot be guaranteed if the agent cannot come up within a reasonable amount of
time.

Fixes: #6215

Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf added a commit that referenced this pull request Feb 4, 2019
When the allocation CIDR changes, the existing code errored out. When that
happened on the first agent restart, all existing endpoints failed to restore
due to failure to allocate the existing endpoint's IP address. The failure to
restore would then in turn get all existing endpoints deleted.

This is bad in two ways:

1. It causes all endpoints to be removed, causing the pods to restart
2. It does not allow the agent to ever come up again without intervention from
   the user.

This commit solves problem #2 to allow nodes to recover automatically. It does
not solve problem #1 yet and requires pods to restart.

Solving problem #2 only makes sense once we have isolated all datapath aspects
such as the DNS proxy and L7 proxies out of the agent as endpoint connetivity
cannot be guaranteed if the agent cannot come up within a reasonable amount of
time.

Fixes: #6215

Signed-off-by: Thomas Graf <thomas@cilium.io>
ianvernon pushed a commit that referenced this pull request Feb 4, 2019
[ upstream commit 0b3ed95 ]

When the allocation CIDR changes, the existing code errored out. When that
happened on the first agent restart, all existing endpoints failed to restore
due to failure to allocate the existing endpoint's IP address. The failure to
restore would then in turn get all existing endpoints deleted.

This is bad in two ways:

1. It causes all endpoints to be removed, causing the pods to restart
2. It does not allow the agent to ever come up again without intervention from
   the user.

This commit solves problem #2 to allow nodes to recover automatically. It does
not solve problem #1 yet and requires pods to restart.

Solving problem #2 only makes sense once we have isolated all datapath aspects
such as the DNS proxy and L7 proxies out of the agent as endpoint connetivity
cannot be guaranteed if the agent cannot come up within a reasonable amount of
time.

Fixes: #6215

Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Ian Vernon <ian@cilium.io>
ianvernon pushed a commit that referenced this pull request Feb 4, 2019
[ upstream commit 0b3ed95 ]

When the allocation CIDR changes, the existing code errored out. When that
happened on the first agent restart, all existing endpoints failed to restore
due to failure to allocate the existing endpoint's IP address. The failure to
restore would then in turn get all existing endpoints deleted.

This is bad in two ways:

1. It causes all endpoints to be removed, causing the pods to restart
2. It does not allow the agent to ever come up again without intervention from
   the user.

This commit solves problem #2 to allow nodes to recover automatically. It does
not solve problem #1 yet and requires pods to restart.

Solving problem #2 only makes sense once we have isolated all datapath aspects
such as the DNS proxy and L7 proxies out of the agent as endpoint connetivity
cannot be guaranteed if the agent cannot come up within a reasonable amount of
time.

Fixes: #6215

Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Ian Vernon <ian@cilium.io>
karina-ranadive pushed a commit to karina-ranadive/cilium that referenced this pull request Jan 23, 2026
…mplementation-in-cilium

Add Gateway API datapath walkthrough
yoursanonymous pushed a commit to yoursanonymous/cilium that referenced this pull request Jan 31, 2026
fix: set illustration absolute in Hero
yoursanonymous pushed a commit to yoursanonymous/cilium that referenced this pull request Jan 31, 2026
yoursanonymous pushed a commit to yoursanonymous/cilium that referenced this pull request Jan 31, 2026
@bbourchanin bbourchanin mentioned this pull request Feb 23, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants