Multi stage docker build by jrajahalme · Pull Request #2452 · cilium/cilium

jrajahalme · 2018-01-04T19:22:04Z

Use staged Docker builds to use prebuilt Envoy dependencies.

Staged Docker build requires the build to be done on new enough Docker
(e.g. Docker 17.09), but k8s does not support any Docker version that
is new enough. As a workaround the docker build step in k8s testsuite
is performed in a new builder VM using newer docker. The k8s VM keep
using older docker but pull Cilium images from the new builder VM. The
builder VM can be killed after k8s VMs have pulled the images so the
overall resource consumption should not increase significantly.

As part of this change we give the main Cilium directory to docker
build, but with a generated .dockerignore file that avoids sending
over the git directory.

The new Dockerfile refers to prebuilt builder and runtime images,
built with Dockerfile.builder and Dockerfile.runtime, respectively
(both located in contrib/packaging/docker/). The prebuilt images are
to be built using "make docker-image-builder" and "make
docker-image-runtime" at the repo top level directory. Newly built
builder and runtime images need to be pushed to Docker Hub before they
can be used by the main Dockerfile for building Cilium using the date
(format YYYY-MM-DD) as the image tag. Finally, the main Dockerfile
needs to be updated in the repo with the new tags.

Signed-off-by: Jarno Rajahalme jarno@covalent.io

Use multi - staged Docker builds to use prebuilt Envoy dependencies.

aanm · 2018-01-04T19:29:22Z

Do we need this amount of memory and cpu for the registry?

It is not just registry, but also the build VM. On my testing C++ build of Cilium Envoy filters fails with 2GB, but succeeds with 3GB. Also, we delete this VM before we we start running the tests in the other two, so the peak memory use should not increase much.

An enhancement as a follow-up could be to use a lighter-weight image - doesn't have to be a part of this ticket, though IMO.

renamed the new VM as Ray suggested. It is now called 'builder' which should avoid future confusion here as well :-)

I tested builder with 1 CPU and 1GB of memory and it works, so I'll modify this PR accordingly. I'll also roll back the change in number of CPUs on the k8s nodes, I wanted to test if it impacts the runtime but then did not follow through actually timing it.

manalibhutiyani · 2018-01-04T19:45:37Z

Added the release note and label.

raybejjani

Nothing blocking.
I'm curious, why did all the test CA certs change?

raybejjani · 2018-01-05T11:09:08Z

I'd suggest the tag also include a revision for that day. This allows us to push hotfixes to images more than once a day, and then avoid ambiguity over which actual image is being run on machines during these bugfix pushes. An alternative would be to have hour:minute on there too but that has a similar problem on a minute time scale.

Builder and runtime base images are not very likely to be re-created very often. Especially for the builder image I do not see a scenario where hotfixes would be needed, as bazel build cache will just become less useful it becomes out-of-date.

Generally, using the git sha as the tag would be most accurate, but even that does not cover the fact that some runtime and build tool dependencies are not explicitly managed, but we install the latest version available via apt.

So I though using a date would strike a good balance here, implicitly conveying a notion of freshness. Nothing prevents adding retagging the images manually after a build with a more detailed tag either.

That said, the above is all there is to the choice of the automatically generated tag, open to more discussion and viewpoints as always :-)

This will totally work as-is. I was projecting some mostly forgotten issue I once had (all I do remember is having to retrofit the revision onto the date tag). In this case, especially, it's pretty easy to fix it with the manual tagging, as you said. +1

raybejjani · 2018-01-05T11:38:25Z

Probably out of scope for this PR but this might be simpler with go list -f '{{ join .GoFiles " "}}' ./...

I tried this and it produces a list without any directory hierarchy: ```
can't load package: package github.com/cilium/cilium/common/tests: C source files not allowed when not using cgo or SWIG: bpf-event-test.c
cilium_client.go
daemon_client.go get_config_parameters.go get_config_responses.go get_debuginfo_parameters.go get_debuginfo_responses.go get_healthz_parameters.go get_healthz_responses.go patch_config_parameters.go patch_config_responses.go
...

boo. Ignore me. I thought I'd tested it and it had fuller paths but I think there's some other template combination we need to throw in. Not worth it to investigate further.

raybejjani · 2018-01-05T11:40:21Z

Probably out of scope for this PR but this might be more reliable using BPF_FILES from https://github.com/cilium/cilium/blob/master/daemon/bpf.sha#L3

raybejjani · 2018-01-05T11:41:53Z

typo in prunend

Fixed, thanks!

raybejjani · 2018-01-05T11:51:55Z

Why not give this a more descriptive name? It's transient, as you say, and it doesn't run k8s. envoy-builder-registry (or something) would make it clearer if, for example, we leak VMs on a build machine one day.

Most likely I initially thought I could use the same loop that loops from 1 to 2 to also configure the new VM. That turned out not to be the case, so I'll experiment with a more descriptive name.

Either way, the certs need to be regenerated as the IP address of the registry node needs to be in a cert. I guess we could use a separate, completely new cert for the registry node and leave the k8s cluster cert untouched, but that would have been more work and more new files in the repo. I'm leaning for someone more experienced working with certs fixing this up later, though.

Ah, I didn't realise there was this much interrrelation between the certs and nodes. I see you renamed it below which more than addresses my primary concern. Thanks.

ianvernon · 2018-01-05T17:39:26Z

@jrajahalme please rebase and trigger another build; the issue faced in the most recent build here that failed is fixed by #2458 which has been merged to master.

jrajahalme · 2018-01-05T22:10:27Z

registry VM renamed as 'builder', CPU and RAM reduced to defaults (1/1GB). Memory may need to be increased later if C++ compile failures show up.

ianvernon

Amazing work!

manalibhutiyani · 2018-01-06T01:57:37Z

@jrajahalme could you please rebase?

aanm · 2018-01-08T13:31:23Z

What happens when using NFS and not rsync?

GIT_VERSION file is used only if .git directory does not exist. However, I see that envoy/SOURCE_VERSION is used by the bazel scripts whenever it exists, so I'll have to hix that!

I modified the envoy/bazel/get_workspace_status script to ignore envoy/SOURCE_VERSION if git repo is available.

Use staged Docker builds to use prebuilt Envoy dependencies. Staged Docker build requires the build to be done on new enough Docker (e.g. Docker 17.09), but k8s does not support any Docker version that is new enough. As a workaround the docker build step in k8s testsuite is performed in a new builder VM using newer docker. The k8s VM keep using older docker but pull Cilium images from the new builder VM. The builder VM can be killed after k8s VMs have pulled the images so the overall resource consumption should not increase significantly. As part of this change we give the main Cilium directory to docker build, but with a generated .dockerignore file that avoids sending over the git directory. The new Dockerfile refers to prebuilt builder and runtime images, built with Dockerfile.builder and Dockerfile.runtime, respectively (both located in contrib/packaging/docker/). The prebuilt images are to be built using "make docker-image-builder" and "make docker-image-runtime" at the repo top level directory. Newly built builder and runtime images need to be pushed to Docker Hub before they can be used by the main Dockerfile for building Cilium using the date (format YYYY-MM-DD) as the image tag. Finally, the main Dockerfile needs to be updated in the repo with the new tags. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

Create a new VM 'k8s0' to run docker registry and docker build with new enough Docker CE that supports staged builds. 'k8s1' and 'k8s2' are still running older Docker as required for Kubernetes. 'k8s0' is destroyed after the other nodes have pulled the Cilium image to limit resource use during k8s tests. The number of available CPUs for 'k8s1' and 'k8s2' is increased to 4 each in hopes of making the tests run a little faster. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

This makes the release and k8s tests use Envoy by default. Runtime-tests are still run also with the go proxy code. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

At least locally rsyncing the cilium directory takes a long time. Try to cut this down by not syncinfg the .git directory when BUILD_NUMBER is defined. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

Use daemon/bpf.sha as the authoritative list of bpf files. Suggested-by: Ray Bejjani <ray@covalent.io>

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

'k8s0' VM is running k8s, but as the docker builder and registry. Rename it as 'builder' to reflect this. Suggested-by: Ray Bejjani <ray@covalent.io> Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

Revert changes for k8s VM CPU counts and make the builder VM smaller. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

Use SOURCE_VERSION only if git is not available. For actual build the SHA of the git HEAD is always used, but for dependencies build the SHA of the Envoy dependency is used instead. GIT_VERSION was already ignored if .git directory exists. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

jrajahalme · 2018-01-08T17:56:03Z

bpf changes are limited to the bpf/Makefile, where cleant-tags target is moved around so that it is available with and without PKG_BUILD so that "make clean" works in both cases.

jrajahalme · 2018-01-08T17:59:22Z

Still trying to figure out what kind of doc changes may be needed. Do we have any documentation of the docker build process anywhere?

jrajahalme · 2018-01-08T19:10:00Z

test-me-please

manalibhutiyani

Could you please rebase the branch?

manalibhutiyani · 2018-01-09T05:56:12Z

+WORKDIR /go/src/github.com/cilium/cilium
+ADD . ./
+#
+# Please do not add any dependency updates before the 'make install' here,


If this is really important and will tend to break envoy, do you want add a comment which will get ones attention

# ********** WARNING ********** # Please do not add any dependency updates before the 'make install' here,

Feel free to ignore, if you feel this is unnecessary

As the previous commit mentions, this does not occur on main, v1.16, and v1.15 due to cilium#29036. However, in v1.14 and v1.13, we need to take special care because the NameManager and SelectorCache lock can be taken while the Endpoint lock is held during Endpoint deletion. Here are the relevant stacktraces regarding the deadlock: ``` 1: sync.Mutex.Lock [75 minutes] [Created by http.(*Server).Serve in goroutine 1699 @ server.go:3086] sync sema.go:77 runtime_SemacquireMutex(*uint32(0x5), false, 43690) sync mutex.go:171 (*Mutex).lockSlow(*Mutex(cilium#1733)) sync mutex.go:90 (*Mutex).Lock(...) sync rwmutex.go:147 (*RWMutex).Lock(*RWMutex(0xb0)) fqdn name_manager.go:70 (*NameManager).Lock(0xffffffffffffffff) policy selectorcache.go:964 (*SelectorCache).RemoveSelectors(cilium#1088, {cilium#28569, 0xb, 1}, {cilium#643, cilium#32582}) policy l4.go:810 (*L4Filter).removeSelectors(cilium#32582, cilium#29992) policy l4.go:817 (*L4Filter).detach(cilium#719, cilium#29993) policy l4.go:988 L4PolicyMap.Detach(...) policy l4.go:1179 (*L4Policy).Detach(cilium#20318, cilium#1383) policy resolve.go:103 (*selectorPolicy).Detach(...) policy distillery.go:81 (*PolicyCache).delete(cilium#1354, cilium#19354) policy distillery.go:138 (*PolicyCache).LocalEndpointIdentityRemoved(cilium#523, cilium#1163) identitymanager manager.go:167 (*IdentityManager).remove(cilium#706, cilium#19354) identitymanager manager.go:147 (*IdentityManager).Remove(cilium#706, cilium#19354) identitymanager manager.go:52 Remove(...) endpoint endpoint.go:1146 (*Endpoint).leaveLocked(cilium#1883, cilium#12221, {0x30, 0}) endpoint endpoint.go:2192 (*Endpoint).Delete(cilium#1883, {0x80, 0xaa}) endpointmanager manager.go:380 (*EndpointManager).removeEndpoint(cilium#1161, 0, {0xff, 0xff}) endpointmanager manager.go:394 (*EndpointManager).RemoveEndpoint(...) cmd endpoint.go:684 (*Daemon).deleteEndpointQuiet(...) cmd endpoint.go:666 (*Daemon).deleteEndpoint(cilium#1155, cilium#1883) cmd endpoint.go:713 (*Daemon).DeleteEndpoint(cilium#1155, {cilium#27399, cilium#8108}) cmd endpoint.go:770 (*deleteEndpointID).Handle(cilium#21193, {cilium#2452, {cilium#27399, 0x4d}}) endpoint delete_endpoint_id.go:66 (*DeleteEndpointID).ServeHTTP(cilium#5934, {cilium#666, cilium#2242}, cilium#2452) middleware operation.go:28 (*Context).RoutesHandler.NewOperationExecutor.func1({cilium#666, cilium#2242}, cilium#2452) http server.go:2136 HandlerFunc.ServeHTTP(ReadCloser(cilium#130), func{cilium#2242, 0x3}) middleware router.go:78 NewRouter.func1({cilium#666, cilium#2242}, cilium#2451) http server.go:2136 HandlerFunc.ServeHTTP(ReadCloser(cilium#718), func{cilium#2242, #59}) middleware redoc.go:72 Redoc.func1({cilium#666, cilium#2242}, cilium#1251) http server.go:2136 HandlerFunc.ServeHTTP(ReadCloser(cilium#4920), func{cilium#2242, #45}) middleware spec.go:46 Spec.func1({cilium#666, cilium#2242}, cilium#4921) http server.go:2136 HandlerFunc.ServeHTTP(ReadCloser(cilium#10532), func{cilium#2242, cilium#23015}) metrics middleware.go:64 (*APIEventTSHelper).ServeHTTP(cilium#1459, {cilium#668, cilium#10533}, cilium#2451) api apipanic.go:42 (*APIPanicHandler).ServeHTTP(cilium#722, {cilium#668, cilium#10533}, cilium#4922) http server.go:2938 serverHandler.ServeHTTP(*Server(cilium#8105), cilium#668, cilium#10533, 0x6) http server.go:2009 (*conn).serve(*conn(cilium#16005), Context{cilium#673, cilium#1554}) 8: sync.Mutex.Lock [74 minutes] [Created by http.(*Server).Serve in goroutine 1699 @ server.go:3086] sync sema.go:77 runtime_SemacquireMutex(*, 0x47, cilium#1154) sync mutex.go:171 (*Mutex).lockSlow(cilium#706) sync mutex.go:90 (*Mutex).Lock(...) sync rwmutex.go:147 (*RWMutex).Lock(*) identitymanager manager.go:99 (*IdentityManager).RemoveOldAddNew(cilium#706, 0, cilium#1154) identitymanager manager.go:123 RemoveOldAddNew(...) endpoint policy.go:852 (*Endpoint).SetIdentity(*, cilium#1154, 0) endpoint endpoint.go:1932 (*Endpoint).identityLabelsChanged(*, {cilium#674, *}, 1) endpoint endpoint.go:1780 (*Endpoint).runIdentityResolver(*, {cilium#674, *}, 1, 1) endpoint endpoint.go:1720 (*Endpoint).UpdateLabels(*, {cilium#674, *}, *, *, 8) cmd endpoint.go:477 (*Daemon).createEndpoint(cilium#1155, {cilium#673, *}, {cilium#683, cilium#1155}, *) cmd endpoint.go:542 (*putEndpointID).Handle(cilium#21192, {*, *, {*, 0xe}}) endpoint put_endpoint_id.go:58 (*PutEndpointID).ServeHTTP(cilium#3961, {cilium#666, *}, *) middleware operation.go:28 (*Context).RoutesHandler.NewOperationExecutor.func1({cilium#666, *}, *) http server.go:2136 HandlerFunc.ServeHTTP(*, {cilium#666, *}, *) middleware router.go:78 NewRouter.func1({cilium#666, *}, *) http server.go:2136 HandlerFunc.ServeHTTP(*, {cilium#666, *}, *) middleware redoc.go:72 Redoc.func1({cilium#666, *}, cilium#1251) http server.go:2136 HandlerFunc.ServeHTTP(*, {cilium#666, *}, #45) middleware spec.go:46 Spec.func1({cilium#666, *}, *) http server.go:2136 HandlerFunc.ServeHTTP(*, {cilium#666, *}, *) metrics middleware.go:64 (*APIEventTSHelper).ServeHTTP(cilium#1459, {cilium#668, *}, *) api apipanic.go:42 (*APIPanicHandler).ServeHTTP(#49, {cilium#668, *}, *) http server.go:2938 serverHandler.ServeHTTP({cilium#653}, {cilium#668, *}, 6) http server.go:2009 (*conn).serve(*, {cilium#673, cilium#1554}) 5: sync.Mutex.Lock [75 minutes] [Created by eventqueue.(*EventQueue).Run in goroutine 1482 @ eventqueue.go:229] sync sema.go:77 runtime_SemacquireMutex(cilium#142, 0xe8, *) sync mutex.go:171 (*Mutex).lockSlow(cilium#1733) sync mutex.go:90 (*Mutex).Lock(...) sync rwmutex.go:147 (*RWMutex).Lock(0x68) fqdn name_manager.go:70 (*NameManager).Lock(*) policy selectorcache.go:798 (*SelectorCache).AddFQDNSelector(cilium#1088, {cilium#643, *}, {{*, 0x4d}, {0, 0}}) policy l4.go:628 (*L4Filter).cacheFQDNSelector(...) policy l4.go:623 (*L4Filter).cacheFQDNSelectors(*, {*, 4, cilium#193}, cilium#536) policy l4.go:725 createL4Filter({cilium#680, *}, {*, 1, 1}, 0, {cilium#660, *}, {{*, 4}, ...}, ...) policy l4.go:879 createL4EgressFilter(...) policy rule.go:717 mergeEgressPortProto({cilium#680, *}, #44, {*, 0xa, 0}, *, {cilium#660, *}, {{*, ...}, ...}, ...) policy rule.go:672 mergeEgress.func1({cilium#660, *}) api l4.go:284 PortRules.Iterate({*, 1, cilium#546}, *) policy rule.go:624 mergeEgress({cilium#680, *}, *, {*, 1, 1}, 0, {cilium#661, *}, {cilium#662, ...}, ...) policy rule.go:753 (*rule).resolveEgressPolicy(*, {cilium#680, *}, *, *, *, {0, 0, 0}, {0, ...}) policy rules.go:103 ruleSlice.resolveL4EgressPolicy({*, *, *}, {cilium#680, *}, *) policy repository.go:718 (*Repository).resolvePolicyLocked(cilium#1089, *) policy distillery.go:119 (*PolicyCache).updateSelectorPolicy(cilium#1354, *) policy distillery.go:153 (*PolicyCache).UpdatePolicy(...) endpoint policy.go:262 (*Endpoint).regeneratePolicy(*) endpoint bpf.go:744 (*Endpoint).runPreCompilationSteps(*, *, *) endpoint bpf.go:589 (*Endpoint).regenerateBPF(*, *) endpoint policy.go:457 (*Endpoint).regenerate(*, *) endpoint events.go:53 (*EndpointRegenerationEvent).Handle(*, *) eventqueue eventqueue.go:245 (*EventQueue).run.func1() sync once.go:74 (*Once).doSlow(*, *) sync once.go:65 (*Once).Do(...) eventqueue eventqueue.go:233 (*EventQueue).run(*) 1: select [75 minutes] [Created by eventqueue.(*EventQueue).Run in goroutine 1482 @ eventqueue.go:229] semaphore semaphore.go:60 (*Weighted).Acquire(cilium#1092, {cilium#671, cilium#722}, cilium#766) lock semaphored_mutex.go:30 (*SemaphoredMutex).Lock(...) ipcache ipcache.go:140 (*IPCache).Lock(...) ipcache cidr.go:56 (*IPCache).AllocateCIDRs(cilium#1316, {0, 0, cilium#2037}, {0, 0, 0}, 0) ipcache cidr.go:103 (*IPCache).AllocateCIDRsForIPs(0, {0, cilium#697, 0}, 0xffffffffffffffff) cmd identity.go:114 cachingIdentityAllocator.AllocateCIDRsForIPs(...) policy selectorcache.go:509 (*SelectorCache).allocateIdentityMappings(cilium#1088, {{0, 0}, {cilium#5036, 0x2b}}, #45) policy selectorcache.go:843 (*SelectorCache).AddFQDNSelector(cilium#1088, {cilium#643, cilium#27811}, {{0, 0}, {cilium#5036, 0x2b}}) policy l4.go:628 (*L4Filter).cacheFQDNSelector(...) policy l4.go:623 (*L4Filter).cacheFQDNSelectors(cilium#27811, {cilium#42936, 0x287, cilium#193}, cilium#536) policy l4.go:725 createL4Filter({cilium#680, cilium#22826}, {cilium#22828, 1, 1}, 0, {cilium#660, cilium#24510}, {{cilium#4487, 3}, ...}, ...) policy l4.go:879 createL4EgressFilter(...) policy rule.go:717 mergeEgressPortProto({cilium#680, cilium#22826}, #44, {cilium#22828, 0xa, #78536}, #79633, {cilium#660, cilium#24510}, {{cilium#4487, ...}, ...}, ...) policy rule.go:672 mergeEgress.func1({cilium#660, cilium#24510}) api l4.go:284 PortRules.Iterate({cilium#24510, 1, cilium#546}, cilium#11741) policy rule.go:624 mergeEgress({cilium#680, cilium#22826}, cilium#18687, {cilium#22828, 1, 1}, 0, {cilium#661, cilium#5624}, {cilium#662, ...}, ...) policy rule.go:753 (*rule).resolveEgressPolicy(cilium#24575, {cilium#680, cilium#22826}, cilium#18687, cilium#29345, cilium#4782, {0, 0, 0}, {0, ...}) policy rules.go:103 ruleSlice.resolveL4EgressPolicy({cilium#10690, 0xb, 5}, {cilium#680, cilium#22826}, cilium#18687) policy repository.go:718 (*Repository).resolvePolicyLocked(cilium#1089, cilium#18461) policy distillery.go:119 (*PolicyCache).updateSelectorPolicy(cilium#1354, cilium#18461) policy distillery.go:153 (*PolicyCache).UpdatePolicy(...) endpoint policy.go:262 (*Endpoint).regeneratePolicy(cilium#1748) endpoint bpf.go:744 (*Endpoint).runPreCompilationSteps(cilium#1748, cilium#27542, cilium#4781) endpoint bpf.go:589 (*Endpoint).regenerateBPF(cilium#1748, cilium#27542) endpoint policy.go:457 (*Endpoint).regenerate(cilium#1748, cilium#27542) endpoint events.go:53 (*EndpointRegenerationEvent).Handle(cilium#18609, cilium#703) eventqueue eventqueue.go:245 (*EventQueue).run.func1() sync once.go:74 (*Once).doSlow(*Once(cilium#45414), func(cilium#69)) sync once.go:65 (*Once).Do(...) eventqueue eventqueue.go:233 (*EventQueue).run(cilium#6023) ``` Generated from pp tool: https://github.com/maruel/panicparse Signed-off-by: Chris Tarazi <chris@isovalent.com>

jrajahalme requested review from aanm and ianvernon as code owners January 4, 2018 19:22

jrajahalme requested a review from a team January 4, 2018 19:22

jrajahalme requested review from a team as code owners January 4, 2018 19:22

jrajahalme requested a review from a team January 4, 2018 19:22

aanm requested changes Jan 4, 2018

View reviewed changes

manalibhutiyani added the release-note/major This PR introduces major new functionality to Cilium. label Jan 4, 2018

jrajahalme requested a review from aanm January 4, 2018 21:20

jrajahalme added area/CI Continuous Integration testing issue or flake area/docker Impacts the integration with Docker. requires-doc-change Requires updates to the documentation as part of the development effort. labels Jan 4, 2018

jrajahalme force-pushed the multi-stage-docker-build branch 2 times, most recently from e324ad3 to 32c3c02 Compare January 4, 2018 22:03

raybejjani approved these changes Jan 5, 2018

View reviewed changes

jrajahalme force-pushed the multi-stage-docker-build branch 2 times, most recently from b399edb to d2f122d Compare January 5, 2018 21:35

ianvernon added the pending-review label Jan 5, 2018

ianvernon approved these changes Jan 5, 2018

View reviewed changes

aanm reviewed Jan 8, 2018

View reviewed changes

jrajahalme added 5 commits January 8, 2018 09:27

Dockerfile: Enable Envoy by default.

87fa5e2

This makes the release and k8s tests use Envoy by default. Runtime-tests are still run also with the go proxy code. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

Vagrantfile: Avoid syncing .git for CI builds.

ab3c8de

At least locally rsyncing the cilium directory takes a long time. Try to cut this down by not syncinfg the .git directory when BUILD_NUMBER is defined. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

Makefile: Use daemon/bpf.sha.

ffe8a32

Use daemon/bpf.sha as the authoritative list of bpf files. Suggested-by: Ray Bejjani <ray@covalent.io>

jrajahalme added 4 commits January 8, 2018 09:27

Makefile: Fix typo.

34333a8

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

tests/k8s: Rename 'k8s0' as 'builder'

e634bd1

'k8s0' VM is running k8s, but as the docker builder and registry. Rename it as 'builder' to reflect this. Suggested-by: Ray Bejjani <ray@covalent.io> Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

tests/k8s/Vagrantfile: Roll back VM CPUs, memory.

9410198

Revert changes for k8s VM CPU counts and make the builder VM smaller. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>

jrajahalme force-pushed the multi-stage-docker-build branch from d2f122d to 56979e6 Compare January 8, 2018 17:28

jrajahalme requested a review from aanm January 8, 2018 17:32

aanm approved these changes Jan 8, 2018

View reviewed changes

manalibhutiyani approved these changes Jan 9, 2018

View reviewed changes

raybejjani merged commit 00ee001 into master Jan 9, 2018

raybejjani deleted the multi-stage-docker-build branch January 9, 2018 10:17

This was referenced Jan 9, 2018

do not version cilium/dependencies image #1769

Closed

WIP Update vagrantfile #2341

Closed

aanm mentioned this pull request Jan 11, 2018

Dockerfile: adding envoy Dockerfile #2268

Closed

Conversation

jrajahalme commented Jan 4, 2018 • edited by manalibhutiyani Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manalibhutiyani commented Jan 4, 2018

Uh oh!

raybejjani left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ianvernon commented Jan 5, 2018

Uh oh!

jrajahalme commented Jan 5, 2018

Uh oh!

ianvernon left a comment

Choose a reason for hiding this comment

Uh oh!

manalibhutiyani commented Jan 6, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrajahalme commented Jan 8, 2018

Uh oh!

jrajahalme commented Jan 8, 2018

Uh oh!

jrajahalme commented Jan 8, 2018

Uh oh!

manalibhutiyani left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jrajahalme commented Jan 4, 2018 •

edited by manalibhutiyani

Loading