Skip to content

Tests: Fix issues with GSG test#2458

Merged
tgraf merged 1 commit intocilium:masterfrom
eloycoto:gsgFix
Jan 5, 2018
Merged

Tests: Fix issues with GSG test#2458
tgraf merged 1 commit intocilium:masterfrom
eloycoto:gsgFix

Conversation

@eloycoto
Copy link
Copy Markdown
Member

@eloycoto eloycoto commented Jan 5, 2018

Fix indention problems on minicube yamls that cause a fail on kubernetes
master test.

Fail log message:

error validating "/home/vagrant/go/src/github.com/cilium/cilium/tests/k8s/tests/deployments/gsg/demo.yaml": error validating data: found invalid field nodeSelector for v1beta1.DeploymentSpec; if you choose to ignore these errors, turn validation off with --validate=false

Generated demo.yaml file:

---
apiVersion: v1
kind: Service
metadata:
  name: app1-service
spec:
  ports:
  - port: 80
  selector:
    id: app1
---
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: app1
spec:
  replicas: 2
  template:
    metadata:
      labels:
        id: app1
    spec:
      containers:
      - name: web
        image: cilium/demo-httpd
        ports:
        - containerPort: 80
      nodeSelector:
        "kubernetes.io/hostname": k8s-1
---
apiVersion: v1
kind: Pod
metadata:
  name: app2
  labels:
    id: app2
spec:
  containers:
  - name: app-frontend
    image: cilium/demo-client
    command: [ "sleep" ]
    args:
      - "1000h"
  nodeSelector:
    "kubernetes.io/hostname": k8s-1
---
apiVersion: v1
kind: Pod
metadata:
  name: app3
  labels:
    id: app3
spec:
  containers:
  - name: app-frontend
    image: cilium/demo-client
    command: [ "sleep" ]
    args:
      - "1000h"
  nodeSelector:
    "kubernetes.io/hostname": k8s-1

Fix indention problems on minicube yamls that cause a fail on kubernetes
master test.

Fail log message:

```
error validating "/home/vagrant/go/src/github.com/cilium/cilium/tests/k8s/tests/deployments/gsg/demo.yaml": error validating data: found invalid field nodeSelector for v1beta1.DeploymentSpec; if you choose to ignore these errors, turn validation off with --validate=false
```

Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
@eloycoto eloycoto added the area/CI Continuous Integration testing issue or flake label Jan 5, 2018
@eloycoto eloycoto requested review from a team and techcet January 5, 2018 11:52
@tgraf tgraf merged commit 5078434 into cilium:master Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/CI Continuous Integration testing issue or flake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants