Conversation
Change to Storybook 9.0.0 (+alpha) compatibility
add sb canary compatibility
Upgrade to SB9 alpha
…date-to-new-status-api
…al-tests into update-to-new-status-api
JReinhold
added a commit
to storybookjs/storybook
that referenced
this pull request
Mar 14, 2025
ghengeveld
approved these changes
Mar 17, 2025
| "typeId": "chromaui/addon-visual-tests", | ||
| "value": "status-value:success", | ||
| }, | ||
| ] |
Member
There was a problem hiding this comment.
This is a deviation from our current behavior, but I think it's an improvement.
| expect(args.updateBuildStatus).toHaveBeenCalledWith([]); | ||
| }); | ||
| }, | ||
| } satisfies Story; |
Member
There was a problem hiding this comment.
It's purpose is to visualize the "empty" state of a branch, where no builds have been run against it yet.
The custom render function is just a hack to work around the fact that updateBuildStatus used to accept a callback function besides a value.
9d442d5 to
e9a2346
Compare
…al-tests into update-to-new-status-api
Member
|
@JReinhold shouldn't this be labeled |
This was referenced May 21, 2025
Member
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to use the new status API
📦 Published PR as canary version:
3.2.7--canary.359.a5dfe67.0✨ Test out this PR locally via:
npm install @chromatic-com/storybook@3.2.7--canary.359.a5dfe67.0 # or yarn add @chromatic-com/storybook@3.2.7--canary.359.a5dfe67.0Version
Published prerelease version:
v4.0.0-next.3Changelog
💥 Breaking Change
🚀 Enhancement
🐛 Bug Fix
nextAuthors: 3