Skip to content

Update usages to match Storybook 9.0.0-alpha.4#364

Merged
JReinhold merged 3 commits intonextfrom
sb9-breaking-changes
Mar 17, 2025
Merged

Update usages to match Storybook 9.0.0-alpha.4#364
JReinhold merged 3 commits intonextfrom
sb9-breaking-changes

Conversation

@JReinhold
Copy link
Copy Markdown
Contributor

@JReinhold JReinhold commented Mar 14, 2025

Replaces #361

Updates to Storybook 9.0.0-alpha.4 and updates imports and usages to match:

  • storybook/internal/manager-api -> storybook/manager-api
  • storybook/internal/theming -> storybook/theming
  • @storybook/addon-actions -> fn() from storybook/test
📦 Published PR as canary version: 3.2.7--canary.364.e9a2346.0

✨ Test out this PR locally via:

npm install @chromatic-com/storybook@3.2.7--canary.364.e9a2346.0
# or 
yarn add @chromatic-com/storybook@3.2.7--canary.364.e9a2346.0

@JReinhold JReinhold changed the title Update imports to match Storybook 9.0.0-alpha.4 Update imports and usages to match Storybook 9.0.0-alpha.4 Mar 14, 2025
@JReinhold JReinhold added enhancement Classification: Improvement to existing feature release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Mar 14, 2025
@JReinhold JReinhold self-assigned this Mar 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 3.50877% with 55 lines in your changes missing coverage. Please review.

Project coverage is 5.84%. Comparing base (7dca927) to head (c0a0a14).
Report is 113 commits behind head on next.

Files with missing lines Patch % Lines
src/components/TooltipMenu.stories.tsx 0.00% 20 Missing ⚠️
src/components/SidebarBottom.stories.tsx 0.00% 4 Missing and 1 partial ⚠️
src/components/SidebarTopButton.stories.tsx 20.00% 4 Missing ⚠️
...screens/VisualTests/SnapshotComparison.stories.tsx 0.00% 4 Missing ⚠️
src/screens/VisualTests/StoryInfo.stories.tsx 0.00% 4 Missing ⚠️
...c/screens/VisualTests/SnapshotControls.stories.tsx 0.00% 3 Missing ⚠️
src/components/BrowserSelector.stories.ts 0.00% 2 Missing ⚠️
src/components/ModeSelector.stories.ts 0.00% 2 Missing ⚠️
src/components/SidebarToggleButton.stories.ts 0.00% 1 Missing and 1 partial ⚠️
.../screens/Authentication/Authentication.stories.tsx 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@          Coverage Diff          @@
##            next    #364   +/-   ##
=====================================
  Coverage   5.84%   5.84%           
=====================================
  Files        177     176    -1     
  Lines      14879   14877    -2     
  Branches     310     309    -1     
=====================================
  Hits         870     870           
+ Misses     13920   13919    -1     
+ Partials      89      88    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

package.json Outdated
"urql": "^4.0.3",
"uuid": "^9.0.0",
"vite": "^4.1.4",
"vite": "^6.2.1",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was necessary as the build was failing otherwise.

@JReinhold JReinhold marked this pull request as ready for review March 14, 2025 20:41
Copy link
Copy Markdown
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to rebase off of @ndelangen's branch, so this one basically just does the action -> fn conversion.

#361

@JReinhold JReinhold changed the base branch from next to norbert/cpc-completion March 17, 2025 12:30
@JReinhold JReinhold force-pushed the sb9-breaking-changes branch from 9d442d5 to e9a2346 Compare March 17, 2025 12:31
@JReinhold JReinhold changed the title Update imports and usages to match Storybook 9.0.0-alpha.4 Update usages to match Storybook 9.0.0-alpha.4 Mar 17, 2025
@JReinhold JReinhold added skip-release Auto: Preserve the current version when merged and removed release Auto: Create a `latest` release when merged labels Mar 17, 2025
Base automatically changed from norbert/cpc-completion to next March 17, 2025 13:08
@JReinhold JReinhold merged commit f074fe7 into next Mar 17, 2025
9 of 11 checks passed
@JReinhold JReinhold deleted the sb9-breaking-changes branch March 17, 2025 13:08
@ghengeveld
Copy link
Copy Markdown
Member

🚀 PR was released in v4.0.0 🚀

@ghengeveld ghengeveld added released Verdict: This issue/pull request has been released and removed prerelease labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Classification: Improvement to existing feature patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants