Merged
Conversation
ermalkaleci
added a commit
to AcalaNetwork/Acala
that referenced
this pull request
Jan 18, 2022
Update when this gets merged chevdor/srtool-actions#9
xlc
pushed a commit
to AcalaNetwork/Acala
that referenced
this pull request
Jan 22, 2022
* srtool with features Update when this gets merged chevdor/srtool-actions#9 * remove new line * fix new line
chevdor
requested changes
Apr 26, 2022
Owner
chevdor
left a comment
There was a problem hiding this comment.
Few small details but thanks a lot for the PR and sorry for the time it took to review. I mainly need those commits to be signed.
Comment on lines
+146
to
+154
| ## Environmental variables | ||
| ``` | ||
| ... | ||
| uses: chevdor/srtool-actions@v* | ||
| env: | ||
| BUILD_OPTS: --features on-chain-release-build # optional: will be passed to docker srtool run cmd | ||
| with: | ||
| ... | ||
| ``` |
Owner
There was a problem hiding this comment.
This repo uses ASCIIDOC for the doc and the .md is generated so your change would be overriden.
Could you please add:
== Environmental variables
[source,bash]
----
...
uses: chevdor/srtool-actions@v*
env:
# optional: will be passed to docker srtool run cmd
BUILD_OPTS: --features on-chain-release-build
with:
...
----
into README_src.adoc at L58 ?
You probably don't have the asciidoc toolchain so don't bother installing it, I will generate the new .md after merging.
Owner
|
As a sidenote, this PR bring the same option than the |
chevdor
approved these changes
Apr 28, 2022
Contributor
Author
|
@chevdor is there going to be a new tag? |
Owner
|
Yes but I want to update the doc and the examples first). |
Roaring0202
pushed a commit
to Roaring0202/Acala
that referenced
this pull request
May 15, 2024
* srtool with features Update when this gets merged chevdor/srtool-actions#9 * remove new line * fix new line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
env.BUILD_OPTS will be passed to docker srtool run command