Skip to content

srtool with features#1799

Merged
xlc merged 3 commits intomasterfrom
srtool-with-features
Jan 22, 2022
Merged

srtool with features#1799
xlc merged 3 commits intomasterfrom
srtool-with-features

Conversation

@ermalkaleci
Copy link
Contributor

Update when this gets merged chevdor/srtool-actions#9

Update when this gets merged chevdor/srtool-actions#9
@ermalkaleci ermalkaleci requested review from syan095 and xlc January 18, 2022 14:45
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1799 (7fa27cb) into master (3672be0) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1799      +/-   ##
==========================================
- Coverage   85.26%   85.06%   -0.21%     
==========================================
  Files          74       75       +1     
  Lines       15957    16067     +110     
==========================================
+ Hits        13606    13667      +61     
- Misses       2351     2400      +49     
Impacted Files Coverage Δ
primitives/src/currency.rs 55.45% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3672be0...7fa27cb. Read the comment docs.

@xlc
Copy link
Member

xlc commented Jan 18, 2022

Can you verify if the resulting wasm is the same as the one from makefile command.

@ermalkaleci ermalkaleci marked this pull request as draft January 19, 2022 15:35
@ermalkaleci ermalkaleci marked this pull request as ready for review January 20, 2022 11:17
@ermalkaleci
Copy link
Contributor Author

Can you verify if the resulting wasm is the same as the one from makefile command.

verified

@xlc xlc merged commit 35078ea into master Jan 22, 2022
@xlc xlc deleted the srtool-with-features branch January 22, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants