Pull #18855: technical quoting can be avoided in yml#18855
Closed
Pankraz76 wants to merge 1 commit into
Closed
Conversation
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 4, 2026
9032082 to
759ca8d
Compare
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 4, 2026
759ca8d to
365c024
Compare
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 4, 2026
365c024 to
cad1a73
Compare
Pankraz76
commented
Feb 4, 2026
| fi | ||
| ;; | ||
|
|
||
| git-check-single-commit) |
Author
There was a problem hiding this comment.
Pankraz76
commented
Feb 4, 2026
| name: "git-check-pull-number" | ||
| command: "./.ci/validation.sh git-check-pull-number" | ||
| name: git-check-single-commit | ||
| command: ./.ci/validation.sh git-check-single-commit |
cad1a73 to
d35794a
Compare
Pankraz76
commented
Feb 4, 2026
| java --version | ||
| echo "IDEA version:" | ||
| echo IDEA version: | ||
| echo $IDEA_VERSION |
Member
There was a problem hiding this comment.
Revert all update for echo. Quotes work better.
It is our style.
Pankraz76
commented
Feb 4, 2026
| - validate-with-maven-script: | ||
| name: "jdk21-package-site" | ||
| name: jdk21-package-site | ||
| image-name: *cs_img |
| spotless: | ||
| jobs: | ||
| - validate-with-maven-script: | ||
| name: spotless |
romani
requested changes
Feb 4, 2026
romani
left a comment
Member
There was a problem hiding this comment.
This should be reverted https://github.com/checkstyle/checkstyle/pull/18855/changes#r2765878118
All other is ok.
CI config technical quoting #18820quoting can be avoided in yml
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 7, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull #18855: technical
quotingcan be avoided in yml