Skip to content

Pull #18820: Consolidate CI config #18819#18820

Closed
Pankraz76 wants to merge 1 commit into
checkstyle:masterfrom
Pankraz76:fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits-fix-ci
Closed

Pull #18820: Consolidate CI config #18819#18820
Pankraz76 wants to merge 1 commit into
checkstyle:masterfrom
Pankraz76:fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits-fix-ci

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Feb 1, 2026

Copy link
Copy Markdown

Pull #18820: Consolidate CI config #18819

items:
we missing:

  • using same image-name: *cs_img
  • grouping of same items like validate-with-maven-script

ordered root trunk:

image image

@Pankraz76 Pankraz76 changed the title Pull #18819: Consolidate CI config Pull #18820: Consolidate CI config #18819 Feb 1, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits-fix-ci branch from d21ca65 to 8d2b70e Compare February 1, 2026 10:14
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits-fix-ci branch from 8d2b70e to 8443462 Compare February 1, 2026 10:26
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits-fix-ci branch from 2a3300d to 0669c8e Compare February 1, 2026 10:27
Comment thread .circleci/config.yml
- run:
name: Print versions
command: |
echo "Maven version:"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is important not to waste the focus and value of the double quote.

This has some implications that should be stated first to highlight them, ensuring they are not lost under the inflationary usage of this character.

Image

Comment thread .circleci/config.yml
name: no-exception-samples-ant
image-name: *cs_img
command: ./.ci/no-exception-test.sh no-exception-samples-ant
quality-assurance:

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the random jobs node before giving it some dedicated group name.

whats a better fit for this group of leftovers?

Comment thread .circleci/config.yml
jobs:
- validate-with-maven-script:
name: "no-exception-only-javadoc"
name: no-exception-lucene-and-others-javadoc

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted and grouped all error and exception stuff.

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much off topic.

Please learn how to contribute with one goal a nothing else

@Pankraz76

Copy link
Copy Markdown
Author

yes this the draft to be reduced off and copied out of each dedicated change.

Is the double quotes something we can fix upfront ?

its helpful if there are only chars if technically needed which is sometimes the case.

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026
@romani

romani commented Feb 4, 2026

Copy link
Copy Markdown
Member

I gave a lot warnings.
Now you have last.
Screenshot_20260204-123152

If you continue to send us any updates you like, I will close all your PRs, and bam you.

No extra, or unrelated changes ever!!!!
No pushing to GitHub again and again. You killing our CI.

@Pankraz76 Pankraz76 closed this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants