Skip to content

Issue #18599: Resolve error-prone violations for ObjectEqualsForPrimi…#18625

Closed
VinishaWagh wants to merge 1 commit into
checkstyle:masterfrom
VinishaWagh:errorProne
Closed

Issue #18599: Resolve error-prone violations for ObjectEqualsForPrimi…#18625
VinishaWagh wants to merge 1 commit into
checkstyle:masterfrom
VinishaWagh:errorProne

Conversation

@VinishaWagh

@VinishaWagh VinishaWagh commented Jan 12, 2026 •
edited by romani
Loading

Copy link
Copy Markdown
Contributor

Issue : #18599

https://errorprone.info/bugpattern/ObjectEqualsForPrimitives

This PR handles the violations related to ObjectEqualsForPrimitives for the given files:

LineColumn.java

Violation.java

SuppressWithNearbyCommentFilter.java

SuppressWithPlainTextCommentFilter.java

SuppressionCommentFilter.java

@VinishaWagh

VinishaWagh commented Jan 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hello @romani
for warning in Violation.java, when changed showed error Overly complex boolean expression because equals method combines 11 conditions using &&

final Violation violation = (Violation) object;
return Objects.equals(lineNo, violation.lineNo)
                && Objects.equals(columnNo, violation.columnNo)
                && Objects.equals(columnCharIndex, violation.columnCharIndex)
                && Objects.equals(tokenType, violation.tokenType)
                && Objects.equals(severityLevel, violation.severityLevel)
                && Objects.equals(moduleId, violation.moduleId)
                && Objects.equals(key, violation.key)
                && Objects.equals(bundle, violation.bundle)
                && Objects.equals(sourceClass, violation.sourceClass)
                && Objects.equals(customMessage, violation.customMessage)
                && Arrays.equals(args, violation.args);

to:

final Violation violation = (Violation) object;
return lineNo == violation.lineNo
                && columnNo == violation.columnNo
                && columnCharIndex == violation.columnCharIndex
                && tokenType == violation.tokenType
                && Objects.equals(severityLevel, violation.severityLevel)
                && Objects.equals(moduleId, violation.moduleId)
                && Objects.equals(key, violation.key)
                && Objects.equals(bundle, violation.bundle)
                && Objects.equals(sourceClass, violation.sourceClass)
                && Objects.equals(customMessage, violation.customMessage)
                && Arrays.equals(args, violation.args);

Should we suppress this error?

@Pankraz76

Pankraz76 commented Jan 12, 2026 •
edited
Loading

Copy link
Copy Markdown

plz activate ObjectEqualsForPrimitives as error if fixed.

like seen in:

This was referenced Jan 12, 2026
Merged
Merged
@VinishaWagh

VinishaWagh commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

@Pankraz76
Violation.java is still left to be resolved... which is why I didn't activate it...
But once I get the next command, I'll surely add it...

@Pankraz76 Pankraz76 mentioned this pull request Jan 12, 2026
Closed
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 12, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
d9cf25b 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 12, 2026
Pull checkstyle#18629: Add OptionalRulesRecipes checkstyle#18627 ch…
708c1a7 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 12, 2026
Pull checkstyle#18629: Add OptionalRulesRecipes checkstyle#18627 ch…
b5212dd 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 12, 2026
Pull checkstyle#18629: Add OptionalRulesRecipes checkstyle#18627 ch…
e2b228c 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 12, 2026
Pull checkstyle#18629: Add OptionalRulesRecipes checkstyle#18627 ch…
bad2169 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 12, 2026
Pull checkstyle#18629: Add OptionalRulesRecipes checkstyle#18627 ch…
a7892c9 
…eckstyle#18625 checkstyle#18622
@Pankraz76 Pankraz76 mentioned this pull request Jan 12, 2026
Closed
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 12, 2026
Pull checkstyle#18631: Add OptionalRulesRecipes checkstyle#18629 ch…
88f5288 
…eckstyle#18627 checkstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 12, 2026
Pull checkstyle#18631: Add OptionalRulesRecipes checkstyle#18629 ch…
96523bd 
…eckstyle#18627 checkstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 13, 2026
@Pankraz76
Pull checkstyle#18631: Add OptionalRulesRecipes checkstyle#18629 ch…
82b23b5 
…eckstyle#18627 checkstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 13, 2026
Pull checkstyle#18631: Add OptionalRulesRecipes checkstyle#18629 ch…
dcabe12 
…eckstyle#18627 checkstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 13, 2026
Pull checkstyle#18631: Add OptionalRulesRecipes checkstyle#18629 ch…
47bb6aa 
…eckstyle#18627 checkstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 13, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
bca1ecc 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 13, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
8afabce 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 13, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
84746b6 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 13, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
529077e 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 13, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
d95a770 
…eckstyle#18625 checkstyle#18622
romani
romani requested changes Jan 14, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to configure error prone to not do violations on n equals implementations ?
Such methods are generated.

@VinishaWagh VinishaWagh force-pushed the errorProne branch 2 times, most recently from db026ce to 14367de Compare January 14, 2026 08:43
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 14, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
4019c09 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 14, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
783880d 
…eckstyle#18625 checkstyle#18622
@VinishaWagh

VinishaWagh commented Jan 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

How to configure error prone to not do violations on n equals implementations ? Such methods are generated.

@romani
I am still figuring out, but I did suppress the warning and the build is now success in local...
Please have a look...

@romani

romani commented Jan 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Suppression
Suppress false positives by adding the suppression annotation @SuppressWarnings("ObjectEqualsForPrimitives") to the enclosing element.

Please apply such annotation to all case, for now all items are wont fix, technically should be fixed, but this code is generated, so consistency is more critical.

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 15, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
7aac01c 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 15, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
84d1c92 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 15, 2026
@Pankraz76
Pull checkstyle#18631: Add OptionalRulesRecipes checkstyle#18629 ch…
373a5fd 
…eckstyle#18627 checkstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 15, 2026
Pull checkstyle#18589: Add EqualityRulesRecipes checkstyle#18627 ch…
a5f43ff 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 15, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
993a512 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 15, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
16161ff 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 15, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
60e15f3 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 16, 2026
@Pankraz76
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
52d0e96 
…eckstyle#18625 checkstyle#18622
romani
romani requested changes Jan 16, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase and :

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/api/Violation.java Outdated
&& Objects.equals(columnNo, violation.columnNo)
&& Objects.equals(columnCharIndex, violation.columnCharIndex)
&& Objects.equals(tokenType, violation.tokenType)
// -@cs[BooleanExpressionComplexity] equals - a lot of fields to check.

@romani romani Jan 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move suppression to https://github.com/checkstyle/checkstyle/blob/master/config/suppressions-xpath.xml
please do same for // -@cs[CyclomaticComplexity] equals - a lot of fields to check.

@romani

romani commented Jan 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

please supppress:

<problems is_local_tool="true">
<problem>
<file>
file://$PROJECT_DIR$/src/main/java/com/puppycrawl/tools/checkstyle/api/Violation.java
</file>
<line>371</line>
<module>project</module>
<package>com.puppycrawl.tools.checkstyle.api</package>
<entry_point TYPE="method" FQNAME="com.puppycrawl.tools.checkstyle.api.Violation boolean equals(java.lang.Object object)"/>
<problem_class id="OverlyComplexBooleanExpression" severity="ERROR" attribute_key="ERRORS_ATTRIBUTES">Overly complex boolean expression</problem_class>
<description>Overly complex boolean expression (11 terms) #loc</description>
<highlighted_element>
lineNo == violation.lineNo && columnNo == violation.columnNo && colu...
</highlighted_element>
<language>JAVA</language>
<offset>15</offset>
<length>643</length>
</problem>
</problems>

thee is no configuration to exclude such methods:
image

@VinishaWagh

VinishaWagh commented Jan 17, 2026

Copy link
Copy Markdown
Contributor Author

Okay, I am on it!

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 18, 2026
Pull checkstyle#18631: Add OptionalRulesRecipes checkstyle#18629 ch…
c36a630 
…eckstyle#18627 checkstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 18, 2026
Pull checkstyle#18631: Add OptionalRulesRecipes checkstyle#18629 ch…
b9e5673 
…eckstyle#18627 checkstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 20, 2026
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
e120acf 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 20, 2026
@Pankraz76
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
c3b89c1 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 21, 2026
@Pankraz76
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
0467f26 
…eckstyle#18625 checkstyle#18622
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Jan 22, 2026
@Pankraz76
Pull checkstyle#18629: Add EqualityRulesRecipes checkstyle#18627 ch…
cc15224 
…eckstyle#18625 checkstyle#18622
romani
romani requested changes Feb 3, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressWithPlainTextCommentFilter.java
* @noinspectionreason EqualsCalledOnEnumConstant - enumeration is needed to keep
* code consistent
* @noinspection ObjectEqualsForPrimitives
* @noinspectionreason ObjectEqualsForPrimitives - this code is generated

@romani romani Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is broken here
We do -Xep:ObjectEqualsForPrimitives:ERROR
And now we need suppression of Idea inspection in such places

@Brijeshthummar02

Brijeshthummar02 commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

@VinishaWagh the ObjectEqualsForPrimitives is already been fixed , and merged.
You can close the PR.

@romani romani closed this Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VinishaWagh @Pankraz76 @romani @Brijeshthummar02