Issue #18599: Fix ObjectEqualsForPrimitives violations#18622
Closed
abhayrajjais01 wants to merge 1 commit into
Closed
Issue #18599: Fix ObjectEqualsForPrimitives violations#18622abhayrajjais01 wants to merge 1 commit into
abhayrajjais01 wants to merge 1 commit into
Conversation
Pankraz76
suggested changes
Jan 12, 2026
Pankraz76
left a comment
There was a problem hiding this comment.
well done but please dont kill other check.
| -Xep:MockitoStubbing:ERROR | ||
| -Xep:NestedOptionals:ERROR | ||
| -Xep:OptionalOrElseGet:ERROR | ||
| -Xep:PrimitiveComparison:ERROR |
There was a problem hiding this comment.
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 12, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 12, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 12, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 12, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 12, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 12, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 12, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 12, 2026
617ba97 to
1b74267
Compare
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 13, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 13, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 13, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 13, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 13, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 13, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 13, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 13, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 14, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 14, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 15, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 15, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 15, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 15, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 15, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 15, 2026
4c1e2a9 to
032b9c7
Compare
5ab640b to
5bc734b
Compare
Author
|
@romani |
romani
requested changes
Jan 17, 2026
| -Xep:NestedOptionals:ERROR | ||
| -Xep:OptionalOrElseGet:ERROR | ||
| -Xep:PrimitiveComparison:ERROR | ||
| -Xep:ObjectEqualsForPrimitives:ERROR |
Member
There was a problem hiding this comment.
I do not see in PR fixes for code.
but in issue there are violations:
[INFO] --- compiler:3.14.1:compile (error-prone-compile) @ checkstyle ---
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 473 source files with javac [debug release 21] to target/classes
Warning: /home/runner/work/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/api/LineColumn.java:[88,30] [ObjectEqualsForPrimitives] Avoid unnecessary boxing by using plain == for primitive types.
(see https://errorprone.info/bugpattern/ObjectEqualsForPrimitives)
Did you mean 'return (line == lineColumn.line)'?
Warning: /home/runner/work/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/api/LineColumn.java:[89,34] [ObjectEqualsForPrimitives] Avoid unnecessary boxing by using plain == for primitive types.
(see https://errorprone.info/bugpattern/ObjectEqualsForPrimitives)
Did you mean '&& (column == lineColumn.column);'?
Warning: /home/runner/work/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/api/Violation.java:[367,30] [ObjectEqualsForPrimitives] Avoid unnecessary boxing by using plain == for primitive types.
(see https://errorprone.info/bugpattern/ObjectEqualsForPrimitives)
Did you mean 'return (lineNo == violation.lineNo)'?
There was a problem hiding this comment.
have kind of the same issue.
await this one to do the job as ci going crazy on this.
57df818 to
0d440e0
Compare
…Prone configuration
0d440e0 to
a067204
Compare
Member
|
@abhayrajjais01 , you have 0 chance to be merged if you keep unrelated changes in PR. |
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 18, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 18, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 20, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 20, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 21, 2026
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Jan 22, 2026
Member
|
Issue is closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
#18599