Issue #17487: Add `UpdateMavenWrapper` by Pankraz76 · Pull Request #18434 · checkstyle/checkstyle

Pankraz76 · 2025-12-26T18:24:50Z

Issue #17487: Add `UpdateMavenWrapper`

romani

items:

Pankraz76

2ct. please make me contributor too, or at least put me in check group. Im serving this project like no other.

Pankraz76 · 2025-12-27T11:29:27Z


 @REM ----------------------------------------------------------------------------
-@REM Apache Maven Wrapper startup batch script, version 3.3.2
+@REM Apache Maven Wrapper startup batch script, version 3.3.4


idk, lets just keep it to somehow how can handle this kind of issue. Like the computer itself in the form of rewrite bump. This setup seems to be ongoing broken.

Lets fix this...

Pankraz76 · 2025-12-27T12:18:28Z

 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-wrapperVersion=3.3.2


when updating locally its outdated as well.

Pankraz76 · 2025-12-27T12:19:52Z

@@ -1,3 +1,7 @@
+distributionSha256Sum=305773a68d6ddfd413df58c82b3f8050e89778e777f3a745c8e5b8cbea4018ef


putting this first. Wrapper updated mvn wrapper:wrapper breaks this if header is first. This fine this way and still quite the same, right?

Pankraz76 · 2025-12-27T12:21:39Z

why is this diff? Rewrite runs fine.

Exclude external and generated files from spell checking #18453

diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties
index 614699eb9..48a56c99a 100644
--- a/.mvn/wrapper/maven-wrapper.properties
+++ b/.mvn/wrapper/maven-wrapper.properties
@@ -1,7 +1,3 @@
-distributionSha256Sum=305773a68d6ddfd413df58c82b3f8050e89778e777f3a745c8e5b8cbea4018ef
-distributionType=only-script
-distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.12/apache-maven-3.9.12-bin.zip
-wrapperVersion=3.3.4
 # Licensed to the Apache Software Foundation (ASF) under one
 # or more contributor license agreements.  See the NOTICE file
 # distributed with this work for additional information
@@ -18,3 +14,6 @@ wrapperVersion=3.3.4
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+wrapperVersion=3.3.2
+distributionType=only-script
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.6/apache-maven-3.9.6-bin.zip

Exited with code exit status

Pankraz76 · 2025-12-27T15:44:03Z

ci seems broken.

Issue #17487: Add ECMAScript6BestPractices #18158

Pankraz76 · 2025-12-29T11:35:25Z

why is suggestion wrong?

777 also not working so idk what to do, please suggest fix @romani.

Expected mode for non '.sh' files is 664.
Files that violates this rule:
./mvnw.cmd

https://app.circleci.com/pipelines/github/checkstyle/checkstyle/39398/workflows/8f3db960-5a85-46aa-9fac-4c728caa1e0c/jobs/1208956

Pankraz76 · 2025-12-29T12:04:34Z

reopen after feedback

why is suggestion wrong?

777 also not working so idk what to do, please suggest fix @romani.
``` Expected mode for non '.sh' files is 664. Files that violates this rule: ./mvnw.cmd ```

https://app.circleci.com/pipelines/github/checkstyle/checkstyle/39398/workflows/8f3db960-5a85-46aa-9fac-4c728caa1e0c/jobs/1208956

romani · 2025-12-29T17:01:32Z

This validation for sh files, it should not target cmd files at all.

Pankraz76 · 2025-12-30T06:52:03Z

not target cmd files at all.

but it is,

why the error then?

Expected mode for non '.sh' files is 664.
Files that violates this rule:
./mvnw.cmd

Pankraz76 force-pushed the fix-EndOfLineAtEndOfFile-UpdateMavenWrapper branch from afa967e to 3f7a50a Compare December 26, 2025 18:25

Pankraz76 commented Dec 26, 2025

View reviewed changes

Comment thread config/rewrite.yml

Pankraz76 force-pushed the fix-EndOfLineAtEndOfFile-UpdateMavenWrapper branch from 3f7a50a to 9a080c5 Compare December 26, 2025 18:28

romani requested changes Dec 27, 2025

View reviewed changes

Comment thread config/rewrite.yml

This was referenced Dec 27, 2025

Issue #17487: Add EmptyNewlineAtEndOfFile #18196 #18432 #18433

Closed

Pull #18439: Fix skipMavenParsing #18439

Closed

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

035843e

Pankraz76 force-pushed the fix-EndOfLineAtEndOfFile-UpdateMavenWrapper branch from 0822ea2 to 8b82e28 Compare December 27, 2025 11:25

Pankraz76 changed the title ~~Issue #17487: Add UpdateMavenWrapper Fix skipMavenParsing~~ Issue #17487: Add UpdateMavenWrapper Dec 27, 2025

Pankraz76 force-pushed the fix-EndOfLineAtEndOfFile-UpdateMavenWrapper branch from 8b82e28 to 3cc38e4 Compare December 27, 2025 11:27

Pankraz76 commented Dec 27, 2025

View reviewed changes

Pankraz76 marked this pull request as ready for review December 27, 2025 11:30

Pankraz76 requested a review from romani December 27, 2025 11:30

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

3c5a158

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

b50cc43

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

c9f9940

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

83260c5

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

7846a08

Pankraz76 force-pushed the fix-EndOfLineAtEndOfFile-UpdateMavenWrapper branch from 3cc38e4 to 248ac2b Compare December 27, 2025 11:41

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

028e9e4

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

afb45d6

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

ca61160

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix CI spotless config checkstyle#18434

c8025ab

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix CI spotless config checkstyle#18434

5041f2b

Pankraz76 force-pushed the fix-EndOfLineAtEndOfFile-UpdateMavenWrapper branch 2 times, most recently from d54b309 to 6b9bfc4 Compare December 27, 2025 12:17

Pankraz76 commented Dec 27, 2025

View reviewed changes

Pankraz76 force-pushed the fix-EndOfLineAtEndOfFile-UpdateMavenWrapper branch from 6b9bfc4 to 52d7483 Compare December 27, 2025 12:18

Pankraz76 commented Dec 27, 2025

View reviewed changes

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

126f990

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

0a91c22

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

f446845

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

fd76370

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

c4ac83c

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

68d4d67

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

a1106c1

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Dec 27, 2025

Issue checkstyle#17487: Fix skipMavenParsing checkstyle#18434

4d8f9ec

Pankraz76 closed this Dec 27, 2025

Pankraz76 reopened this Dec 28, 2025

Pankraz76 force-pushed the fix-EndOfLineAtEndOfFile-UpdateMavenWrapper branch 7 times, most recently from 0ef1c6c to da6e74d Compare December 29, 2025 11:08

Pankraz76 mentioned this pull request Dec 29, 2025

Exclude external and generated files from spell checking #18453

Closed

Pankraz76 force-pushed the fix-EndOfLineAtEndOfFile-UpdateMavenWrapper branch 3 times, most recently from f613e60 to 152f9bd Compare December 29, 2025 11:26

Issue checkstyle#17487: Add UpdateMavenWrapper

87d8d88

Pankraz76 force-pushed the fix-EndOfLineAtEndOfFile-UpdateMavenWrapper branch from 152f9bd to 87d8d88 Compare December 29, 2025 11:27

Issue checkstyle#17487: Add UpdateMavenWrapper

c879521

Pankraz76 closed this Dec 29, 2025

		@@ -1,3 +1,7 @@
		distributionSha256Sum=305773a68d6ddfd413df58c82b3f8050e89778e777f3a745c8e5b8cbea4018ef

Uh oh!

Conversation

Pankraz76 commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!