Issue #17487: Add `ECMAScript6BestPractices` by Pankraz76 · Pull Request #18158 · checkstyle/checkstyle

Pankraz76 · 2025-11-24T10:03:08Z

Issue #17487: apply `ECMAScript6BestPractices`

Pankraz76 · 2025-11-24T11:44:17Z

nice to see rewrite also fixing .js stuff as well.

[INFO] Printing available datatables to: target/rewrite/datatables/2025-11-24_11-00-28-110 [WARNING] The recipe produced 20 warning(s). Please report this to the recipe author. [WARNING] Changes have been made to src/site/resources/js/anchors.js by:
[WARNING]     org.openrewrite.codemods.ecmascript.5to6.ECMAScript6BestPractices
[WARNING]         org.openrewrite.codemods.ecmascript.5to6.varToLet
[WARNING]             org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/let.js}
[WARNING]         org.openrewrite.codemods.ecmascript.5to6.noStrict
[WARNING]             org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/no-strict.js}
[WARNING]         org.openrewrite.codemods.ecmascript.5to6.amdToEsm
[WARNING]             org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/amd.js}
[WARNING] Changes have been made to src/site/resources/js/checkstyle.js by:
[WARNING]     org.openrewrite.codemods.ecmascript.5to6.ECMAScript6BestPractices
[WARNING]         org.openrewrite.codemods.ecmascript.5to6.noStrict
[WARNING]             org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/no-strict.js}
[WARNING]         org.openrewrite.codemods.ecmascript.5to6.amdToEsm
[WARNING]             org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/amd.js}
[WARNING] Changes have been made to src/site/resources/styleguides/google-java-style-20180523/include/styleguide.js by:
[WARNING]     org.openrewrite.codemods.ecmascript.5to6.ECMAScript6BestPractices
[WARNING]         org.openrewrite.codemods.ecmascript.5to6.varToLet
[WARNING]             org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/let.js}
[WARNING] Changes have been made to src/site/resources/styleguides/google-java-style-20220203/include/styleguide.js by:
[WARNING]     org.openrewrite.codemods.ecmascript.5to6.ECMAScript6BestPractices
[WARNING]         org.openrewrite.codemods.ecmascript.5to6.varToLet
[WARNING]             org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/let.js}
[WARNING] Changes have been made to src/site/resources/styleguides/google-java-style-20250426/include/styleguide.js by:
[WARNING]     org.openrewrite.codemods.ecmascript.5to6.ECMAScript6BestPractices
[WARNING]         org.openrewrite.codemods.ecmascript.5to6.varToLet
[WARNING]             org.openrewrite.codemods.ApplyCodemod: {transform=5to6-codemod/transforms/let.js}
[WARNING] Please review and commit the results.
[WARNING] Estimate time saved: 25m
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:29 min
[INFO] Finished at: 2025-11-24T11:00:28+01:00
[INFO] ------------------------

Pankraz76 · 2025-11-24T11:59:19Z

item

Finished at: 2025-11-24T11:58:12Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project sample: failed to get report for org.apache.maven.plugins:maven-checkstyle-plugin: Plugin org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1 or one of its dependencies could not be resolved:
[ERROR]         Could not find artifact com.puppycrawl.tools:checkstyle:jar:1.0.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots)
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project sample: failed to get report for org.apache.maven.plugins:maven-checkstyle-plugin
    at org.apache.

Pankraz76 · 2025-12-05T13:58:10Z

wait for enabler, thx.

Pankraz76 · 2025-12-27T15:43:43Z

tryout pipeline with this, reopen.

Issue #18470: Align spotbugs and pmd config with rewrite #18454 #18479 #18440

Pankraz76 · 2025-12-28T10:47:39Z

IO: [ERROR] exceptionMessage: "Connection refused"

romani

Items

romani · 2025-12-29T17:59:58Z

@smita1078 , @stoyanK7 , do you agree with such js updates?

smita1078 · 2025-12-29T19:05:57Z

@smita1078 , @stoyanK7 , do you agree with such js updates?

I’m okay with these JS updates.
That said, these changes are not purely cosmetic:
var -> let changes scoping rules
"use strict" was removed, which weakens runtime safety guarantees

Even if the current behavior is unchanged, better to handle them in a separate PR

romani · 2025-12-29T19:50:34Z

@smita1078 , if you think that some update should not be done, please state it and we will not do it.
Code should not become weaker , even it works same after update.

We show do update only if it is beneficial.

Pankraz76 · 2025-12-30T09:06:29Z

var -> let changes scoping rules

yes of course this is considered benefit as smallest scope possible always the best.

If not possible to use let this something is an issue or an valid ignore.

"use strict" was removed, which weakens runtime safety guarantees

yes then undo.

Pankraz76 · 2025-12-30T09:19:58Z

var -> let changes scoping rules

After actually considering the code, most of the mutability turned out to be obsolete, as usual, so const seems to be a better fit. There are actually only two fields that change over time, coupling the whole code together.

Everything else has been boiled down to a minimal version, avoiding unnecessary coupling and promoting cohesion instead.

Pankraz76

low quality, low cohesion, high violations, high coupling.

Pankraz76 · 2025-12-30T09:20:19Z

            }
-
-            var name = anchorItem.previousSibling.previousElementSibling.id;
-            var link = "" + url + "#" + name + "";


Pankraz76 · 2025-12-30T09:21:05Z

            } else {
                name = anchorItem.childNodes[0].name;
            }
-            var link = "" + url + "#" + name + "";


dry 14 lines. C&P

smita1078 · 2025-12-30T09:45:16Z

var -> let changes scoping rules

yes of course this is considered benefit as smallest scope possible always the best.

If not possible to use let this something is an issue or an valid ignore.

"use strict" was removed, which weakens runtime safety guarantees

yes then undo.

Agreed!, I think keeping strict mode avoids unnecessary risk. Better to not remove it. Thanks

romani · 2026-01-02T05:24:36Z

@smita1078 , please help to review this PR.

if you notice that this is no good direction, we can close this PR. JS is not primary in our repository, some not-perfect code is ok.

Pankraz76 · 2026-01-02T06:39:45Z

not-perfect code is ok

its not non perfect is has worst quality possible.

Its just working (by accident) just like the remaining code base, how needs this silly thing?

smita1078 · 2026-01-03T09:29:27Z

@smita1078 , please help to review this PR.

if you notice that this is no good direction, we can close this PR. JS is not primary in our repository, some not-perfect code is ok.

@romani I don’t think the discussion was moving in a productive direction anymore. From a review perspective, I also don’t think this change is needed right now since JS isn’t a primary focus for us.

Pankraz76 · 2026-01-03T09:44:29Z

JS isn’t a primary focus for us.

For me this text lacks a detailed explanation for why something is neither this nor that. It merely repeats the Romani excuse and fails to focus on the matter.

romani · 2026-01-03T22:04:55Z

All changes should have clear definition of problem and clean and exact fix. Reviewers should see all clearly.
If not possible to be done now, ok, it will be done later.

Pankraz76 mentioned this pull request Nov 24, 2025

[rewrite] apply ECMAScript6BestPractices diffplug/spotless#2768

Closed

Pankraz76 force-pushed the pr-ECMAScript6BestPractices branch from d27dbf2 to ed6643c Compare November 24, 2025 11:19

Pankraz76 commented Nov 24, 2025

View reviewed changes

Comment thread src/site/resources/js/checkstyle.js Outdated

Pankraz76 force-pushed the pr-ECMAScript6BestPractices branch from ed6643c to 0615198 Compare November 24, 2025 11:40

Pankraz76 changed the title ~~[rewrite] apply ECMAScript6BestPractices~~ Issue #17487: [rewrite] apply ECMAScript6BestPractices Nov 24, 2025

Pankraz76 force-pushed the pr-ECMAScript6BestPractices branch from 0615198 to d71b00a Compare November 24, 2025 11:44

Pankraz76 force-pushed the pr-ECMAScript6BestPractices branch from a6cec70 to 8899e60 Compare November 24, 2025 11:47

Pankraz76 changed the title ~~Issue #17487: [rewrite] apply ECMAScript6BestPractices~~ Issue #17487: apply ECMAScript6BestPractices Nov 24, 2025

Pankraz76 force-pushed the pr-ECMAScript6BestPractices branch 2 times, most recently from 27b8bfd to ed9d2fb Compare November 24, 2025 13:50

Pankraz76 closed this Dec 5, 2025

Pankraz76 reopened this Dec 27, 2025

This was referenced Dec 27, 2025

Pull #18439: Fix skipMavenParsing #18439

Closed

Issue #17487: Add UpdateMavenWrapper #18434

Closed

Pankraz76 force-pushed the pr-ECMAScript6BestPractices branch 3 times, most recently from be16a73 to 0fa1c73 Compare December 28, 2025 10:38

Pankraz76 marked this pull request as ready for review December 28, 2025 10:47

Pankraz76 changed the title ~~Issue #17487: apply ECMAScript6BestPractices~~ Issue #17487: Add ECMAScript6BestPractices Dec 28, 2025

This was referenced Dec 28, 2025

Add ECMAScript6BestPractices#simpleArrow Pankraz76/openui5#1

Open

Add ECMAScript6BestPractices UI5/openui5#4375

Closed

ECMAScript6BestPractices #18198

Closed

Pankraz76 force-pushed the pr-ECMAScript6BestPractices branch from 0fa1c73 to 876727a Compare December 29, 2025 09:31

romani requested changes Dec 29, 2025

View reviewed changes

Comment thread config/rewrite.yml Outdated

Comment thread config/rewrite.yml Outdated

Pankraz76 force-pushed the pr-ECMAScript6BestPractices branch from 876727a to ac9ccad Compare December 30, 2025 09:16

Pankraz76 commented Dec 30, 2025

View reviewed changes

Pankraz76 requested a review from romani December 30, 2025 09:22

Pankraz76 commented Dec 30, 2025

View reviewed changes

Comment thread src/site/resources/js/anchors.js Outdated

Pankraz76 commented Dec 30, 2025

View reviewed changes

Comment thread src/site/resources/js/anchors.js Outdated

Pankraz76 force-pushed the pr-ECMAScript6BestPractices branch from ac9ccad to e27dc44 Compare December 30, 2025 11:07

Pankraz76 commented Dec 30, 2025

View reviewed changes

Comment thread config/jsoref-spellchecker/whitelist.words

Issue checkstyle#17487: Add ECMAScript6BestPractices

f9a106a

Pankraz76 force-pushed the pr-ECMAScript6BestPractices branch from e27dc44 to f9a106a Compare January 1, 2026 10:59

Pankraz76 closed this Jan 2, 2026

Uh oh!

Conversation

Pankraz76 commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue #17487: apply ECMAScript6BestPractices

Uh oh!

Uh oh!

Pankraz76 commented Nov 24, 2025

Uh oh!

Pankraz76 commented Nov 24, 2025

Uh oh!

Pankraz76 commented Dec 5, 2025

Uh oh!

Pankraz76 commented Dec 27, 2025

Uh oh!

Pankraz76 commented Dec 28, 2025

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

romani commented Dec 29, 2025

Uh oh!

smita1078 commented Dec 29, 2025

Uh oh!

romani commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pankraz76 commented Dec 30, 2025

Uh oh!

Pankraz76 commented Dec 30, 2025

Uh oh!

Pankraz76 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

smita1078 commented Dec 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

romani commented Jan 2, 2026

Uh oh!

Pankraz76 commented Jan 2, 2026

Uh oh!

smita1078 commented Jan 3, 2026

Uh oh!

Pankraz76 commented Jan 3, 2026

Uh oh!

romani commented Jan 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Pankraz76 commented Nov 24, 2025 •

edited

Loading

Issue #17487: apply `ECMAScript6BestPractices`

romani commented Dec 29, 2025 •

edited

Loading

Pankraz76 left a comment •

edited

Loading