Skip to content

Pull #18819: Add validation for single commit in pull #18819

Merged
romani merged 1 commit into
checkstyle:masterfrom
Pankraz76:fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits
Feb 4, 2026
Merged

Pull #18819: Add validation for single commit in pull #18819
romani merged 1 commit into
checkstyle:masterfrom
Pankraz76:fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Feb 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Pull #18819: Add git-check-single-commit #18791

discovered in:

@Pankraz76 Pankraz76 changed the title Pull #18806: Add git-squash-commits #18756 Pull #18819: Add git-squash-commits #18756 Feb 1, 2026
@Pankraz76 Pankraz76 changed the title Pull #18819: Add git-squash-commits #18756 Pull #18819: Add git-squash-commits #18791 Feb 1, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18819: Add git-squash-commits checkstyle#18791
d0432c5
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits branch from 4e864e3 to d0432c5 Compare February 1, 2026 08:51
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18819: Add git-squash-commits checkstyle#18791
e390916
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits branch from d0432c5 to e390916 Compare February 1, 2026 08:52
@Pankraz76 Pankraz76 changed the title Pull #18819: Add git-squash-commits #18791 Pull #18819: Add git-only-squash-commits #18791 Feb 1, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18819: Add git-only-squash-commits checkstyle#18791
094f4db
@Pankraz76 Pankraz76 changed the title Pull #18819: Add git-only-squash-commits #18791 Pull #18819: Add git-check-squash-commit #18791 Feb 1, 2026
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18819: Add git-check-squash-commit checkstyle#18791
9b1947a
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits branch from 094f4db to 9b1947a Compare February 1, 2026 08:57
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18819: Add CI name
d21ca65
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18819: Consolidate CI config
86c5e9d
@Pankraz76

Pankraz76 commented Feb 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

test:

image

negative test:

image image

@Pankraz76

Pankraz76 commented Feb 1, 2026

Copy link
Copy Markdown
Author

@romani

proof:

https://app.circleci.com/pipelines/github/checkstyle/checkstyle/41335/workflows/b2ec43dd-8d8c-4707-b471-c63c2f4a7f83/jobs/1299882

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18819: Add git-check-squash-commit checkstyle#18791
ac01ace
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits branch from 86c5e9d to ac01ace Compare February 1, 2026 09:21
@Pankraz76 Pankraz76 marked this pull request as ready for review February 1, 2026 09:21
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18819: Add git-check-squash-commit checkstyle#18791
8e47502
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits branch from ac01ace to 8e47502 Compare February 1, 2026 09:23
Pankraz76
Pankraz76 commented Feb 1, 2026
View reviewed changes
Comment thread .circleci/config.yml
@Pankraz76 Pankraz76 mentioned this pull request Feb 1, 2026
Closed
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18819: Add git-check-squash-commit checkstyle#18791
9b3f29f
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits branch from 8e47502 to 9b3f29f Compare February 1, 2026 09:51
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18820: Consolidate CI config checkstyle#18819
8d2b70e
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18820: Consolidate CI config checkstyle#18819
8443462
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18820: Consolidate CI config checkstyle#18819
2a3300d
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 1, 2026
Pull checkstyle#18820: Consolidate CI config checkstyle#18819
0669c8e
romani
romani requested changes Feb 2, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all off topic updates.
All

Comment thread .ci/validation.sh
romani
romani requested changes Feb 3, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

Comment thread .ci/validation.sh Outdated
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits branch from 9b3f29f to 314bc61 Compare February 4, 2026 19:27
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026
Pull checkstyle#18819: Add git-check-single-commit checkstyle#18791
314bc61
@Pankraz76 Pankraz76 requested a review from romani February 4, 2026 19:27
@Pankraz76

Pankraz76 commented Feb 4, 2026

Copy link
Copy Markdown
Author

have you blocked me why can i not edit title anymore?

Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026
Pull checkstyle#18819: Add git-check-single-commit checkstyle#18791
a0ff107
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits branch from 314bc61 to a0ff107 Compare February 4, 2026 19:28
Pankraz76 pushed a commit to Pankraz76/checkstyle that referenced this pull request Feb 4, 2026
Pull checkstyle#18819: Add git-check-single-commit checkstyle#18791
07874fb
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits branch from a0ff107 to 07874fb Compare February 4, 2026 19:30
@Pankraz76 Pankraz76 force-pushed the fin-CommonStaticAnalysis-AllRefasterRules-git-squash-commits branch from 07874fb to a716930 Compare February 4, 2026 19:31
romani
romani approved these changes Feb 4, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for compact PR with any unrelated updates

@romani romani changed the title Pull #18819: Add git-check-squash-commit #18791 Pull #18819: Add validation for single commit in pull Feb 4, 2026
@romani

romani commented Feb 4, 2026

Copy link
Copy Markdown
Member

have you blocked me why can i not edit title anymore?

I didn't.
I updated title to follow our rules, do not change it. It will be used in release notes.

@Pankraz76 Pankraz76 mentioned this pull request Feb 4, 2026
Closed
@Pankraz76

Pankraz76 commented Feb 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

old ci was failing on unmatching pr titel i remember very much suffer.. but i like of course the consistency.

@romani

romani commented Feb 4, 2026

Copy link
Copy Markdown
Member

In all next PR use only single # in commit message, all extra details should be in issue description or pull description

@romani romani merged commit 401736b into checkstyle:master Feb 4, 2026
122 checks passed
@github-actions github-actions Bot added this to the 13.2.0 milestone Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

miscellaneous

Projects

None yet

Milestone

13.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @romani