Pass max_bytes parameter to UniversalDetector in detect() and detect_all()#314
Merged
dan-blanchard merged 1 commit intochardet:mainfrom Feb 20, 2026
Merged
Conversation
…all() Both detect() and detect_all() accept a max_bytes parameter but never pass it to the UniversalDetector constructor, so the detector always uses the default of 200,000 regardless of what the caller specifies. This passes max_bytes through so the parameter actually takes effect.
Member
|
Thanks for the fix! |
dan-blanchard
added a commit
that referenced
this pull request
Mar 12, 2026
…arade history - Add contributor names with GitHub profile links to all changelog entries - Add PR/issue links where available across all versions - Add missing entries: 6.0.0.post1, max_bytes fix (#314), Codespaces (#312), LGPLv2.1 update (#307), ISO-8859-15 (#222), LGPL classifier (#255), Hypothesis testing (#66), UTF-16/32 BOM fix (#73), early exit (#103) - Include charade fork releases (1.0.0–1.0.3) interleaved chronologically - Prefix pre-merger versions with "chardet" or "charade" for clarity - Add sphinx-lint to prek pre-commit hooks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detect()anddetect_all()both accept amax_bytesparameter, but neither passes it to theUniversalDetectorconstructor. The detector always uses the default value of 200,000 regardless of what the caller specifies.