stop reading file immediately when filetype known#103
Merged
dan-blanchard merged 1 commit intochardet:masterfrom Apr 10, 2017
Merged
stop reading file immediately when filetype known#103dan-blanchard merged 1 commit intochardet:masterfrom
dan-blanchard merged 1 commit intochardet:masterfrom
Conversation
Member
|
Nice catch! |
Merged
dan-blanchard
added a commit
that referenced
this pull request
Mar 12, 2026
…arade history - Add contributor names with GitHub profile links to all changelog entries - Add PR/issue links where available across all versions - Add missing entries: 6.0.0.post1, max_bytes fix (#314), Codespaces (#312), LGPLv2.1 update (#307), ISO-8859-15 (#222), LGPL classifier (#255), Hypothesis testing (#66), UTF-16/32 BOM fix (#73), early exit (#103) - Include charade fork releases (1.0.0–1.0.3) interleaved chronologically - Prefix pre-merger versions with "chardet" or "charade" for clarity - Add sphinx-lint to prek pre-commit hooks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a useful performance improvement. I've got some 100MB files and they take quite a few seconds to read through from my local SSD - and imagine if someone was reading across the network.
If the unicode byte-order mark is read in the first line of the file, it really makes no sense to read the rest of the file off disk.
I fixed the unit tests in the previous PR because I wanted to assure myself this introduced no regression (it appears not to.)
cheers