Skip to content

Add changelog entry for #9821#9822

Merged
adferrand merged 1 commit intomasterfrom
9821-changelog
Oct 27, 2023
Merged

Add changelog entry for #9821#9822
adferrand merged 1 commit intomasterfrom
9821-changelog

Conversation

@bmw
Copy link
Copy Markdown
Member

@bmw bmw commented Oct 27, 2023

This just does what the title says but here's a link to the relevant PR: #9821

@adferrand adferrand enabled auto-merge (squash) October 27, 2023 17:14
@adferrand adferrand merged commit 7bb85f8 into master Oct 27, 2023
@adferrand adferrand deleted the 9821-changelog branch October 27, 2023 22:04
bmw added a commit that referenced this pull request Oct 27, 2023
(cherry picked from commit 7bb85f8)
bmw added a commit that referenced this pull request Oct 30, 2023
* Set the delegated field in Lexicon config to bypass subdomain resolution (#9821)

The Lexicon-based DNS plugins use a mechanism to determine which actual segment of the input domain is actually the DNS zone in which the DNS-01 challenge has to be initiated (eg. `subdomain.domain.com` or `domain.com` for input `subdomain.domain.com`): they tries recursively to configure Lexicon and initiate authentication from the most specific to most generic domain segment, and select the first segment where Lexicon stop erroring out.

This mechanism broke with #9746 because now the plugins call Lexicon client instead of the underlying providers, and the client makes guess on the actual domain requested. Typically for `subdomain.domain.com` it will actually try to authenticate against `domain.com`, and so the mechanism above does not work anymore.

This PR fixes the issue by using the `delegated` field in Lexicon config each time the plugin needs it. This field is designed for this kind of purpose: it will instruct Lexicon what is the actual DNS zone domain instead of guessing it.

I tested the change with one of my OVH account. The expected behavior is re-established and the plugin is able to test `subdomain.domain.com` then `domain.com` as before.

Fixes #9791
Fixes #9818

(cherry picked from commit cf4f07d)

* add changelog entry for 9821 (#9822)

(cherry picked from commit 7bb85f8)

---------

Co-authored-by: Adrien Ferrand <adferrand@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants