Skip to content

Prep for 2.7.4#9823

Merged
bmw merged 2 commits into2.7.xfrom
prep-2.7.4
Oct 30, 2023
Merged

Prep for 2.7.4#9823
bmw merged 2 commits into2.7.xfrom
prep-2.7.4

Conversation

@bmw
Copy link
Copy Markdown
Member

@bmw bmw commented Oct 27, 2023

No description provided.

adferrand and others added 2 commits October 27, 2023 16:30
…ion (#9821)

The Lexicon-based DNS plugins use a mechanism to determine which actual segment of the input domain is actually the DNS zone in which the DNS-01 challenge has to be initiated (eg. `subdomain.domain.com` or `domain.com` for input `subdomain.domain.com`): they tries recursively to configure Lexicon and initiate authentication from the most specific to most generic domain segment, and select the first segment where Lexicon stop erroring out.

This mechanism broke with #9746 because now the plugins call Lexicon client instead of the underlying providers, and the client makes guess on the actual domain requested. Typically for `subdomain.domain.com` it will actually try to authenticate against `domain.com`, and so the mechanism above does not work anymore.

This PR fixes the issue by using the `delegated` field in Lexicon config each time the plugin needs it. This field is designed for this kind of purpose: it will instruct Lexicon what is the actual DNS zone domain instead of guessing it.

I tested the change with one of my OVH account. The expected behavior is re-established and the plugin is able to test `subdomain.domain.com` then `domain.com` as before.

Fixes #9791
Fixes #9818

(cherry picked from commit cf4f07d)
(cherry picked from commit 7bb85f8)
@bmw bmw merged commit dca4ddd into 2.7.x Oct 30, 2023
@bmw bmw deleted the prep-2.7.4 branch October 30, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants