Add deprecation warnings for deprecated elements in certbot.display.util#8989
Merged
bmw merged 3 commits intocertbot:masterfrom Aug 17, 2021
Merged
Conversation
bmw
reviewed
Aug 16, 2021
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
bmw
approved these changes
Aug 17, 2021
bmw
added a commit
that referenced
this pull request
Aug 30, 2021
Fixes #6844. This PR does two things: 1. Changes ACMEv1 deprecation warnings from `PendingDeprecationWarning` to `DeprecationWarning`. 2. Changes the ACMEv1 deprecation warnings to be on references to the class themselves. This is the approach taken in #8989, the PRs linked there, and the `cryptography` code in the code comment. I think this approach warns in more cases and I updated our unit tests to avoid hitting these warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8982.
This PR takes essentially the same approach than in #8970 and https://github.com/certbot/certbot/pull/6859/files#diff-e5eaf744409c293203b898ba9896da75689fd04ff5f1566c035940a5b195c257