Emit deprecation warnings for Zope interfaces#8970
Merged
alexzorin merged 5 commits intocertbot:masterfrom Aug 14, 2021
Merged
Conversation
alexzorin
approved these changes
Aug 12, 2021
Collaborator
alexzorin
left a comment
There was a problem hiding this comment.
LGTM, seems to do the right thing with third party plugins
alexzorin
requested changes
Aug 12, 2021
Collaborator
alexzorin
left a comment
There was a problem hiding this comment.
Oops, actually, I think we need a CHANGELOG entry for this.
Collaborator
Author
|
Hello @alexzorin, this is done. |
alexzorin
approved these changes
Aug 14, 2021
bmw
added a commit
that referenced
this pull request
Aug 17, 2021
…til (#8989) Fix #8982. This PR takes essentially the same approach than in #8970 and https://github.com/certbot/certbot/pull/6859/files#diff-e5eaf744409c293203b898ba9896da75689fd04ff5f1566c035940a5b195c257 Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #8950, that ensures deprecation warnings are emitted to developers when they try to use the old Zope interfaces. It uses the same approach than for TLS-SNI-01 related objects in the acme project (see #6859).