Conversation
I assume this is just talking about users who are getting certbot-auto updates, right?
That is what this message is for, I think it's appropriate to hit it in this situation. |
ohemorange
left a comment
There was a problem hiding this comment.
Since this affects certbot-auto, we should get a second review. Otherwise, this looks good to me.
This count was of all certbot-auto users, even those using an old version, however, the majority of that number were getting updates.
We don't have anyone available to give a 2nd review at the moment, but that's probably a good idea. I'll ping someone else when we do. |
|
Thanks a lot Adrien 😄 I'm going to hold off on merging this until we have a consensus in #8207. |
|
It should be OK to merge this PR after certbot/website#629 lands. |
Fixes #8150.
You can see the full test suite passing at https://dev.azure.com/certbot/certbot/_build/results?buildId=2464&view=results.
One unfortunate change with this PR is how it affects certbot-auto users on Python 3.5. Using the packages certbot-auto expects, no certbot-auto user should be on Python 3.5. Despite that, ~415 are. I think to get in this state, you need to have done something like:
--no-bootstrapand handled getting the OS packages Certbot needs yourself.USE_PYTHON_3outside of the script (like I did for testing here).Based on my understanding of the script and testing with Python 3.4, once we drop Python 3.5 support and certbot-auto tries to upgrade itself, it will break for users that have managed to configure it to use Python 3.5. If we update
MIN_PYTHON_3_VERSIONlike I did here, that error will be:If we don't update
MIN_PYTHON_3_VERSION, the output will look something like:Either outcome is unfortunate, but I think the first is better. We could leave certbot-auto unchanged if people prefer though.
Despite this downside, I think we should go ahead with this dropping Python 3.5 because:
In the past, we would migrate users we expected to be on that version of Python, but if you were on a different OS, things suddenly broke like this and as far as I know, we never heard about it. I think it's another unfortunate aspect of certbot-auto, but luckily this should be the last time it happens to people!