Add warnings about Python 3.5 deprecation in Certbot#8154
Merged
bmw merged 5 commits intocertbot:masterfrom Jul 21, 2020
Merged
Add warnings about Python 3.5 deprecation in Certbot#8154bmw merged 5 commits intocertbot:masterfrom
bmw merged 5 commits intocertbot:masterfrom
Conversation
Member
|
Looks like lint is angry. |
# Conflicts: # certbot/CHANGELOG.md
bmw
requested changes
Jul 21, 2020
Member
bmw
left a comment
There was a problem hiding this comment.
Other than updating the warning text, this LGTM!
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
bmw
approved these changes
Jul 21, 2020
ohemorange
pushed a commit
that referenced
this pull request
Aug 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8149
This PR adds warnings to warn about the incoming deprecation of Python 3.5 in Certbot.