Update to a supported version of Python#629
Merged
ohemorange merged 1 commit intomasterfrom Aug 16, 2020
Merged
Conversation
ohemorange
approved these changes
Aug 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
certbot/certbot#8206 would have broken website build here because Travis was using Python 3.5.
This PR fixes things by updating Travis to use Ubuntu 20.04 instead of Ubuntu 16.04. I think this upgrade is less scary than it could be because we have node and ruby pinned to specific versions. I tested the built version of the site with this change and didn't notice any difference.
gsfontsis needed because without it we error out trying to build Certbot's docs which you can see at https://travis-ci.com/github/certbot/website/builds/179783766#L1085.Another thing to note here is certbot/certbot#8206 will break the Dockerfile in this repo, but I updated the first post at #621 to mention this and I don't think it's a big deal since we deleted our Docker instructions in #622.