Updates developer documentation to give examples of using make#1023
Updates developer documentation to give examples of using make#1023jetstack-bot merged 5 commits intocert-manager:masterfrom
Conversation
includes rewording and clarifications on CRD documentation and API compatibility guarantees Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Mostly this is just rewording to make things read better, fixing typos and adding clarifications Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
I'd missed this in code review Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| # istioctl install --set profile=openshift -f istio-install-config.yaml | ||
| ``` | ||
|
|
||
| You will be prompted for input to confirm your choice of Istio profile: |
There was a problem hiding this comment.
note: This is just #1022 but copied into next-docs - I didn't spot it when I reviewed that PR, so I'm fixing it here 😁
irbekrm
left a comment
There was a problem hiding this comment.
Thanks @SgtCoDFish !
I've read through the doc and generally this looks good to me- I believe that this is a part that will be changed and improved as we go, so no need to try to get this perfect first time round.
I've added a couple nits, but generally happy to lgtm
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
irbekrm
left a comment
There was a problem hiding this comment.
Thanks for adding the extra info for what go version is used @SgtCoDFish!
I think this is good to be merged now- folks will benefit from knowing/being able to use make
/lgtm
|
|
||
| To return to using your system version of go, run: `make unvendor-go`. | ||
|
|
||
| To check which version of Go is _currently_ being used, run: `make which-go`, which prints the version number of Go and the path to the Go binary. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This replaces a lot of older documentation which referenced bazel, most of which will no longer work. A lot of the docs were incorrect even before we started making the switch to make.
Sorry that this is a large PR; I ended up changing more than I expected because so much of the language was out of date, broken or just wrong. Our DCO signoff page for example still asked that copyright notices mention Jetstack, even though the notices were updated a long time ago!
Important: This PR is smaller than it looks! Since all the changes are duplicated in both docs and next-docs, the lines changed looks twice as big as it actually is!