Modifications after trying the istio-csr tutorial#1022
Modifications after trying the istio-csr tutorial#1022jetstack-bot merged 2 commits intocert-manager:masterfrom davidsbond:patch-1
Conversation
This commit makes two small tweaks to the istio-csr tutorial on the website. The first is that the final clean up command will fail, following the instructions verbatim will produce an error, so it has been updated to just `kind delete cluster`, which successfully deletes the kind cluster. ``` $ kind delete cluster kind ERROR: unknown command "kind" for "kind delete cluster" ``` The second change is to add that the `isitoctl install` command will prompt for user input to confirm the choice of profile. The user should confirm the choice. Signed-off-by: David Bond <davidsbond@users.noreply.github.com>
|
Hi @davidsbond. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/ok-to-test
Thanks for this, looks like a great improvement 👍
|
@davidsbond Annoyingly I think our spell-checker is insisting that it be spelled "Istio" with a capital |
Signed-off-by: David Bond <davidsbond@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidsbond, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'd missed this in code review Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
This commit makes two small tweaks to the istio-csr tutorial on the website.
The first is that the final clean up command will fail, following the instructions verbatim
will produce an error, so it has been updated to just
kind delete cluster, which successfullydeletes the kind cluster.
The second change is to add that the
isitoctl installcommand will prompt for user inputto confirm the choice of profile. The user should confirm the choice.
Signed-off-by: David Bond davidsbond@users.noreply.github.com