Skip to content

Add tests for release-1.17 branch of cert-manager#1074

Merged
SgtCoDFish merged 1 commit into
cert-manager:masterfrom
SgtCoDFish:cm1.17
Jan 30, 2025
Merged

Add tests for release-1.17 branch of cert-manager#1074
SgtCoDFish merged 1 commit into
cert-manager:masterfrom
SgtCoDFish:cm1.17

Conversation

@SgtCoDFish

@SgtCoDFish SgtCoDFish commented Jan 29, 2025

Copy link
Copy Markdown
Member

This follows the release of cert-manager v1.17.0-beta.0

@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 29, 2025
@SgtCoDFish
add tests for release-1.17 branch of cert-manager
ae4aa13 
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@SgtCoDFish

SgtCoDFish commented Jan 29, 2025

Copy link
Copy Markdown
Member Author

See #1061 for an example of doing this for 1.16

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@SgtCoDFish

SgtCoDFish commented Jan 30, 2025

Copy link
Copy Markdown
Member Author

Given that @maelvls approved this but didn't use the lgtm or approve commands, I'll add the label manually since this has clearly been reviewed.

/approve

@cert-manager-prow

cert-manager-prow Bot commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish SgtCoDFish added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@SgtCoDFish SgtCoDFish merged commit f0f1a2b into cert-manager:master Jan 30, 2025
@SgtCoDFish SgtCoDFish deleted the cm1.17 branch January 30, 2025 15:46
@cert-manager-prow

cert-manager-prow Bot commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

@SgtCoDFish: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster default using the following files:
    • key cert-manager-release-1.17.yaml using file config/jobs/cert-manager/cert-manager/release-1.17/cert-manager-release-1.17.yaml
  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/config.yaml
Details

In response to this:

This follows the release of cert-manager v1.17.0-beta.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SgtCoDFish SgtCoDFish mentioned this pull request Feb 10, 2025
Merged
@wallrj wallrj mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maelvls maelvls maelvls approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SgtCoDFish @maelvls