Skip to content

Setup tests for release-1.16#1061

Merged
cert-manager-prow[bot] merged 7 commits into
cert-manager:masterfrom
wallrj:release-1.16
Sep 26, 2024
Merged

Setup tests for release-1.16#1061
cert-manager-prow[bot] merged 7 commits into
cert-manager:masterfrom
wallrj:release-1.16

Conversation

@wallrj

@wallrj wallrj commented Sep 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

As described in the section "Proceed to the post-release "testing and release" steps:" in https://cert-manager.io/docs/contributing/release-process/#minor-releases

Also a couple of drive by fixes.

@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2024
@wallrj wallrj mentioned this pull request Sep 26, 2024
Merged
@wallrj
Add release-1.16 to the testgrid dashboard config
7127f3b 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
Add release-1.16 to the prowgen specs
3f66efa 
Using the same Kubernetes versions as for master

Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
make prowgen
4132d39 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
Update the milestone applier plugin config for release-1.16
def2ddb 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
Add required status checks for release-1.16
8ddb228 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
Drive by fix to match the required checks with the default checks for…
816aced 
… the master branch

Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
Remove out dated comment in prowgen spec
8013ca4 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
wallrj
wallrj commented Sep 26, 2024
View reviewed changes
Comment thread config/config.yaml
Comment thread config/prowgen/prowspecs/specs.go
@wallrj wallrj requested a review from SgtCoDFish September 26, 2024 14:01
SgtCoDFish
SgtCoDFish approved these changes Sep 26, 2024
View reviewed changes

@SgtCoDFish SgtCoDFish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

This looks like what I'd have expected. Thanks 🚀

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@cert-manager-prow

cert-manager-prow Bot commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@cert-manager-prow cert-manager-prow Bot merged commit 96b1e37 into cert-manager:master Sep 26, 2024
@cert-manager-prow

cert-manager-prow Bot commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

@wallrj: Updated the following 3 configmaps:

  • job-config configmap in namespace default at cluster default using the following files:
    • key cert-manager-release-1.16.yaml using file config/jobs/cert-manager/cert-manager/release-1.16/cert-manager-release-1.16.yaml
  • plugins configmap in namespace default at cluster default using the following files:
    • key plugins.yaml using file config/plugins.yaml
  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/config.yaml
Details

In response to this:

As described in the section "Proceed to the post-release "testing and release" steps:" in https://cert-manager.io/docs/contributing/release-process/#minor-releases

Also a couple of drive by fixes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wallrj wallrj deleted the release-1.16 branch September 26, 2024 14:46
@wallrj

wallrj commented Sep 26, 2024

Copy link
Copy Markdown
Member Author

Here's an example of it working:

@SgtCoDFish SgtCoDFish mentioned this pull request Jan 29, 2025
Merged
@wallrj wallrj mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wallrj @SgtCoDFish