Skip to content

Event handler: add support for predicate based filtering#8261

Merged
cert-manager-prow[bot] merged 2 commits intocert-manager:masterfrom
inteon:refactor_event_handler
Dec 9, 2025
Merged

Event handler: add support for predicate based filtering#8261
cert-manager-prow[bot] merged 2 commits intocert-manager:masterfrom
inteon:refactor_event_handler

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented Nov 18, 2025 •
edited by maelvls
Loading

Relates to #8220
depends on #8314

Kind

/kind cleanup

Release Note

NONE

CyberArk tracker: VC-47745

@cert-manager-prow cert-manager-prow bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/acme Indicates a PR directly modifies the ACME Issuer code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2025
@inteon inteon force-pushed the refactor_event_handler branch from a57b702 to d3380eb Compare November 18, 2025 09:26
@inteon inteon mentioned this pull request Nov 18, 2025
Open
@inteon inteon force-pushed the refactor_event_handler branch 2 times, most recently from 6b55316 to ab0cd85 Compare November 19, 2025 14:22
@cert-manager-prow cert-manager-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2025
@inteon inteon force-pushed the refactor_event_handler branch 4 times, most recently from a8f4bf2 to 36236f4 Compare November 20, 2025 08:11
@inteon inteon marked this pull request as draft November 20, 2025 09:10
@cert-manager-prow cert-manager-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2025
lukasmetzner added a commit to hetzner/cert-manager-webhook-hetzner that referenced this pull request Nov 25, 2025
@lukasmetzner
feat: limit failed api requests
49a40b0 
Limit API requests by returning errors without a correlation ID. Correlation ID will be logged in the webhook, but not returned to cert-manager.

Upstream implementations, which would fix the root issue:
- cert-manager/cert-manager#8261
- cert-manager/cert-manager#8220
@lukasmetzner lukasmetzner mentioned this pull request Nov 25, 2025
Merged
lukasmetzner added a commit to hetzner/cert-manager-webhook-hetzner that referenced this pull request Nov 25, 2025
@lukasmetzner
feat: limit failed api requests
ae61260 
Limit API requests by returning errors without a correlation ID. Correlation ID will be logged in the webhook, but not returned to cert-manager.

Upstream implementations, which would fix the root issue:
- cert-manager/cert-manager#8261
- cert-manager/cert-manager#8220
@inteon @wallrj-cyberark
Event handler: add support for predicate based filtering
bce7706 
Co-authored-by: Richard Wall <richard.wall@cyberark.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon force-pushed the refactor_event_handler branch 2 times, most recently from 7395d31 to 24ac4dd Compare December 4, 2025 16:09
@inteon inteon marked this pull request as ready for review December 4, 2025 16:18
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2025
@inteon inteon force-pushed the refactor_event_handler branch from 24ac4dd to a0a605e Compare December 4, 2025 16:33
@inteon
add tests for event handlers
fdc7e41 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2025
@inteon inteon mentioned this pull request Dec 8, 2025
Merged
@inteon inteon force-pushed the refactor_event_handler branch from a0a605e to 59de954 Compare December 8, 2025 08:28
@cert-manager-prow cert-manager-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 8, 2025
@inteon inteon force-pushed the refactor_event_handler branch 2 times, most recently from 101173c to 996ae44 Compare December 8, 2025 08:34
@inteon inteon changed the title Improve event handler: add predicate support & replace deepequal with resource version comparison Event handler: add support for predicate based filtering Dec 8, 2025
@inteon inteon force-pushed the refactor_event_handler branch 9 times, most recently from 6bfff1f to 2574b35 Compare December 8, 2025 12:41
This was referenced Dec 8, 2025
Merged
Closed
@inteon inteon force-pushed the refactor_event_handler branch from 2574b35 to bce7706 Compare December 8, 2025 14:36
maelvls
maelvls reviewed Dec 9, 2025
View reviewed changes
maelvls
maelvls reviewed Dec 9, 2025
View reviewed changes
@inteon inteon force-pushed the refactor_event_handler branch from 49c0058 to fdc7e41 Compare December 9, 2025 12:56
maelvls
maelvls approved these changes Dec 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Dec 9, 2025
@cert-manager-prow cert-manager-prow bot merged commit 33fc9b5 into cert-manager:master Dec 9, 2025
7 checks passed
@maelvls maelvls mentioned this pull request Dec 12, 2025
Open
@wallrj-cyberark wallrj-cyberark added the cybr Used by CyberArk-employed maintainers to report to line management what's being worked on. label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maelvls maelvls maelvls approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code cybr Used by CyberArk-employed maintainers to report to line management what's being worked on. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@inteon @maelvls @wallrj-cyberark