Skip to content

Add predicate filtering to queuing handler#8220

Open
wallrj-cyberark wants to merge 4 commits intocert-manager:masterfrom
wallrj-cyberark:acme-challenge-generation-change-predicate
Open

Add predicate filtering to queuing handler#8220
wallrj-cyberark wants to merge 4 commits intocert-manager:masterfrom
wallrj-cyberark:acme-challenge-generation-change-predicate

Conversation

@wallrj-cyberark
Copy link
Copy Markdown
Member

@wallrj-cyberark wallrj-cyberark commented Oct 31, 2025

  • Register GenerationChangedPredicate for ACME challenge informer
  • Make queuing handler generic and accept typed predicates
  • Evaluate predicates on create/update/delete before enqueueing objects
  • Add typed event handling, tombstone delete support, and logging
NONE

@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Oct 31, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cert-manager-prow cert-manager-prow bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 31, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 31, 2025
@wallrj-cyberark wallrj-cyberark mentioned this pull request Oct 31, 2025
Merged
@wallrj wallrj marked this pull request as ready for review November 2, 2025 09:01
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2025
@wallrj-cyberark wallrj-cyberark force-pushed the acme-challenge-generation-change-predicate branch from 0766fad to 60967e1 Compare November 3, 2025 07:54
@cert-manager-prow cert-manager-prow bot added the area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code label Nov 3, 2025
@wallrj-cyberark wallrj-cyberark force-pushed the acme-challenge-generation-change-predicate branch from 60967e1 to bd2f98f Compare November 4, 2025 07:08
@inteon inteon force-pushed the acme-challenge-generation-change-predicate branch from bd2f98f to 2557b7c Compare November 18, 2025 08:33
@inteon inteon mentioned this pull request Nov 18, 2025
Merged
@inteon
Copy link
Copy Markdown
Member

inteon commented Nov 18, 2025

@wallrj-cyberark I split the eventhandler work into another PR: #8261

@maelvls
Copy link
Copy Markdown
Member

maelvls commented Nov 18, 2025

Hey. What's the purpose of this PR? I imagine it is a follow-up to #8221?

lukasmetzner added a commit to hetzner/cert-manager-webhook-hetzner that referenced this pull request Nov 25, 2025
@lukasmetzner
feat: limit failed api requests
49a40b0 
Limit API requests by returning errors without a correlation ID. Correlation ID will be logged in the webhook, but not returned to cert-manager.

Upstream implementations, which would fix the root issue:
- cert-manager/cert-manager#8261
- cert-manager/cert-manager#8220
@lukasmetzner lukasmetzner mentioned this pull request Nov 25, 2025
Merged
lukasmetzner added a commit to hetzner/cert-manager-webhook-hetzner that referenced this pull request Nov 25, 2025
@lukasmetzner
feat: limit failed api requests
ae61260 
Limit API requests by returning errors without a correlation ID. Correlation ID will be logged in the webhook, but not returned to cert-manager.

Upstream implementations, which would fix the root issue:
- cert-manager/cert-manager#8261
- cert-manager/cert-manager#8220
inteon and others added 4 commits December 4, 2025 15:06
@inteon @wallrj-cyberark
Event handler: add support for predicate based filtering
bce7706 
Co-authored-by: Richard Wall <richard.wall@cyberark.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
Use resource version instead of deepequal when possible
3d7474c 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
Make event handlers correctly typed, using generics
b21a02c 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
Ignore Challenge Status.Reason-only updates
7b4bcad 
- Use typed predicate in acmechallenges to ignore Status.Reason-only
- Remove stabilizeSolverErrorMessage and set Status.Reason to err.Error()

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2025
@inteon inteon force-pushed the acme-challenge-generation-change-predicate branch from 2557b7c to 19260bc Compare December 8, 2025 13:01
@cert-manager-prow cert-manager-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2025
@inteon inteon force-pushed the acme-challenge-generation-change-predicate branch from 19260bc to 4c02232 Compare December 8, 2025 13:06
@inteon inteon mentioned this pull request Dec 8, 2025
Closed
@inteon inteon force-pushed the acme-challenge-generation-change-predicate branch from 4c02232 to 7b4bcad Compare December 8, 2025 14:38
@maelvls maelvls linked an issue Dec 8, 2025 that may be closed by this pull request
Improve cert-manager's event handler to allow us to selectively skip some reconciliations #8319
Open
@maelvls maelvls mentioned this pull request Dec 8, 2025
Open
@maelvls maelvls removed a link to an issue Dec 8, 2025
Improve cert-manager's event handler to allow us to selectively skip some reconciliations #8319
Open
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Dec 8, 2025

@wallrj-cyberark: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-master-e2e-v1-34 7b4bcad link true /test pull-cert-manager-master-e2e-v1-34

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@inteon inteon mentioned this pull request Jan 6, 2026
Open
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2026
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Jan 12, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wallrj-cyberark @inteon @maelvls