Use API defaults for issuerRef fields#7907
Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom Aug 11, 2025
Merged
Use API defaults for issuerRef fields#7907cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
Conversation
erikgb
commented
Aug 10, 2025
erikgb
commented
Aug 10, 2025
| ExpectedEvents: []string{ | ||
| //nolint: dupword | ||
| `Normal Created Created Challenge resource "testorder-756011405" for domain "test.com"`, | ||
| `Normal Created Created Challenge resource "testorder-2580184217" for domain "test.com"`, |
Member
Author
There was a problem hiding this comment.
I am assuming this had to change since the issuer group/kind is part of the order hash name?
SgtCoDFish
reviewed
Aug 11, 2025
Member
SgtCoDFish
left a comment
There was a problem hiding this comment.
Few bits - what do you think? Nothing blocking really but I think it's worth a quick check first!
e742cd7 to
caea9f8
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
caea9f8 to
f1e2d77
Compare
SgtCoDFish
approved these changes
Aug 11, 2025
Member
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Seems fine to me! Thanks 🚀
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Motivation
This is follow-up PR to #7900 and #7892, which leverage the new API defaults from issuerRef fields (group and kind) in our user-facing APIs.. The
defaulter-gensetup seems a bit awkward to me, as the defaulting functions for our public APIs are generated inside the internal API package, but that's how it is. There is probably a reason for it, and I have no plans to change this. But if we had defaults for the equivalent fields in our internal APIs, this could be simplified more.I chose to invoke the defaulting function from our unit-test constructors, as this appears to be the newer way of writing tests.
Kind
/kind cleanup
Release Note