Fix OpenAPI validations by adding API list markers#7900
Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom Aug 7, 2025
Merged
Fix OpenAPI validations by adding API list markers#7900cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
Conversation
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
SgtCoDFish
approved these changes
Aug 7, 2025
Member
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
The default value for x-kubernetes-list-type is atomic, so the vast majority of the changes here are just documenting the default value. The map changes make sense to me - we wouldn't want two image pull secrets with the same name.
LGTM!
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Motivation
Extracted from #7886, this PR adds the
listTypemarker to all array fields in our APIs. In this PR, I am not introducing thesetlist type. We will continue the discussions around this in #7886.Kind
/kind cleanup
Release Note