Skip to content

Migrate all uses of deprecated ObjectReference#7892

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
erikgb:remove-objectref-use
Aug 7, 2025
Merged

Migrate all uses of deprecated ObjectReference#7892
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
erikgb:remove-objectref-use

Conversation

@erikgb
Copy link
Copy Markdown
Member

@erikgb erikgb commented Aug 3, 2025

Pull Request Motivation

In #7414 we deprecated meta.ObjectReference. This removes all use of the deprecated type.

I will try to remove redundant code after introducing these API defaults in a dedicated PR.

Kind

/kind cleanup

Release Note

NONE

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@cert-manager-prow cert-manager-prow bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 3, 2025
@erikgb erikgb requested a review from inteon August 3, 2025 10:20
@cert-manager-prow cert-manager-prow bot added area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/monitoring Indicates a PR or issue relates to monitoring area/testing Issues relating to testing labels Aug 3, 2025
@inteon
Copy link
Copy Markdown
Member

inteon commented Aug 3, 2025

Could you also take a look and remove the in-code defaulting logic?

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Aug 3, 2025

Could you also take a look and remove the in-code defaulting logic?

Yes, I did mention this in the PR description. And I made some attempts here, but it will require refactoring. So I found it better to do this boring stuff in a separate PR - to facilitate review.

Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Simple rename, no reason not to merge! Thanks!

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2025
@cert-manager-prow cert-manager-prow bot merged commit aa0ab1b into cert-manager:master Aug 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/monitoring Indicates a PR or issue relates to monitoring area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants