Skip to content

replace deprecated nose dependency with pynose#1947

Merged
cbodley merged 1 commit intomainfrom
wip-pynose
May 23, 2024
Merged

replace deprecated nose dependency with pynose#1947
cbodley merged 1 commit intomainfrom
wip-pynose

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented May 23, 2024

after upgrading teuthology to centos 9 and python 3.10, the rgw multisite test suite now fails to invoke nosetests with:

AttributeError: module 'collections' has no attribute 'Callable'

this is a known issue tracked in nose-devs/nose#1127

Shilpa found a new 'pynose' package which claims that:

This version of nose is compatible with Python 3.7+ (including 3.13+).

replace the nose dependency that i initially added in #1069 with the current version 1.5.1 of pynose

to prepare this pr, i first changed setup.cfg then ran:

./update-requirements.sh -P "pynose==1.5.1"

Fixes: https://tracker.ceph.com/issues/66183

@cbodley
replace deprecated nose dependency with pynose
73a7948 
after upgrading teuthology to centos 9 and python 3.10, the rgw
multisite test suite now fails to invoke nosetests with:

> AttributeError: module 'collections' has no attribute 'Callable'

this is a known issue tracked in nose-devs/nose#1127

Shilpa found a new 'pynose' package which claims that:

> This version of nose is compatible with Python 3.7+ (including 3.13+).

replace the nose dependency that i initially added in
#1069 with the current version
1.5.1 of pynose

to prepare this pr, i first changed setup.cfg then ran:

> ./update-requirements.sh -P "pynose==1.5.1"

Fixes: https://tracker.ceph.com/issues/66183

Signed-off-by: Casey Bodley <cbodley@redhat.com>
zmc
zmc approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Casey!

@cbodley
Copy link
Contributor Author

cbodley commented May 23, 2024

thanks @zmc. not sure this works yet, tests pending in https://pulpito.ceph.com/cbodley-2024-05-23_16:42:18-rgw:multisite-wip-boost-asio-spawn-unlock-distro-default-smithi/

i first tried https://pulpito.ceph.com/cbodley-2024-05-23_16:37:04-rgw:multisite-wip-boost-asio-spawn-unlock-distro-default-smithi/ but this wip-pynose branch hadn't made it to git.ceph.com yet?

cc @smanjara

@zmc
Copy link
Member

zmc commented May 23, 2024

Sounds good. If the tests pass, feel free to merge. If there are more issues, I can re-review.

@smanjara
Copy link

smanjara commented May 23, 2024

the tests failed due to multisite related errors. Scheduled a new run with two zone configuration

https://pulpito.ceph.com/smanjara-2024-05-23_19:43:45-rgw:multisite-wip-shilpa-multisite-tests-distro-default-smithi/7723368/

@cbodley cbodley merged commit e7ae758 into main May 23, 2024
@cbodley cbodley deleted the wip-pynose branch May 23, 2024 20:28
@cbodley
Copy link
Contributor Author

cbodley commented Jul 9, 2024

@smanjara we'll likely need to reconsider use of this library based on licensing discussions in mdmintz/pynose#16

thanks @adamemerson for the heads-up

@smanjara
Copy link

smanjara commented Jul 9, 2024

@smanjara we'll likely need to reconsider use of this library based on licensing discussions in mdmintz/pynose#16

thanks @adamemerson for the heads-up

ack

cbodley added a commit to cbodley/ceph that referenced this pull request Feb 19, 2026
@cbodley
qa/rgw: bucket notifications use pynose
915a530 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley cbodley mentioned this pull request Feb 19, 2026
Merged
adamemerson pushed a commit to ceph/ceph-ci that referenced this pull request Feb 19, 2026
@cbodley @adamemerson
tentacle: qa/rgw: bucket notifications use pynose
3dd3d03 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
adamemerson pushed a commit to ceph/ceph-ci that referenced this pull request Feb 19, 2026
@cbodley @adamemerson
tentacle: qa/rgw: bucket notifications use pynose
c836833 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
@adamemerson adamemerson mentioned this pull request Feb 20, 2026
Merged
14 tasks
cbodley added a commit to cbodley/ceph that referenced this pull request Feb 20, 2026
@cbodley
qa/rgw: bucket notifications use pynose
a00a856 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
adamemerson pushed a commit to ceph/ceph-ci that referenced this pull request Feb 26, 2026
@cbodley @adamemerson
tentacle: qa/rgw: bucket notifications use pynose
4525be6 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
adamemerson pushed a commit to ceph/ceph-ci that referenced this pull request Mar 3, 2026
@cbodley @adamemerson
tentacle: qa/rgw: bucket notifications use pynose
d73aa89 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
kshtsk pushed a commit to kshtsk/ceph that referenced this pull request Mar 8, 2026
@cbodley
qa/rgw: bucket notifications use pynose
2e5824a 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
kshtsk pushed a commit to kshtsk/ceph that referenced this pull request Mar 8, 2026
@cbodley
qa/rgw: bucket notifications use pynose
569c3e9 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
kshtsk pushed a commit to kshtsk/ceph that referenced this pull request Mar 10, 2026
@cbodley
qa/rgw: bucket notifications use pynose
118d325 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
kshtsk pushed a commit to kshtsk/ceph that referenced this pull request Mar 12, 2026
@cbodley
qa/rgw: bucket notifications use pynose
8ae1e4a 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
kshtsk pushed a commit to kshtsk/ceph that referenced this pull request Mar 12, 2026
@cbodley
qa/rgw: bucket notifications use pynose
2dd9845 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
kshtsk pushed a commit to kshtsk/ceph that referenced this pull request Mar 12, 2026
@cbodley
qa/rgw: bucket notifications use pynose
5b22aa2 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
kshtsk pushed a commit to kshtsk/ceph that referenced this pull request Mar 12, 2026
@cbodley
qa/rgw: bucket notifications use pynose
081e682 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
kginonredhat pushed a commit to kginonredhat/ceph that referenced this pull request Mar 13, 2026
@cbodley @kginonredhat
qa/rgw: bucket notifications use pynose
114862d 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
JonBailey1993 pushed a commit to JonBailey1993/ceph that referenced this pull request Mar 17, 2026
@cbodley @JonBailey1993
qa/rgw: bucket notifications use pynose
d2cf343 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
batrick pushed a commit to cbodley/ceph that referenced this pull request Mar 18, 2026
@cbodley @batrick
qa/rgw: bucket notifications use pynose
c8eb7d9 
nose incompatibility in multisite tests was fixed by switching to pynose
in ceph/teuthology#1947, so i'm trying the same
here

Fixes: https://tracker.ceph.com/issues/74573

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 915a530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmc zmc zmc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbodley @zmc @smanjara