LGTM

thanks @zmc, added a comment. i agree that it's not ideal, but the only alternative i could think of was rewriting all of the existing tests for unittest (someday, maybe..)

Actually, py.test has support for nosetests :) So this shouldn't even be necessary? Also, please keep in mind that even though nosetests is used in the suites, it is no longer maintained, and that has been the case for a while.

hi @alfredodeza, i'm not familiar with py.test, but that sounds promising. are there any examples you could point me at?

there are quite a few known issues running nosetests using py.test, https://docs.pytest.org/en/latest/nose.html, Better to run them with nose than with py.test

@cbodley I think that if you just try pytest instead of nose as the executable, things should just work.

Certainly, like @vasukulkarni points out, there is no 100% support for everything nose has (e.g. classes that don't inherit from unittest.TestCase will not work), but worth give it a shot to help transition the tests to a supported test runner.

@cbodley I think that if you just try pytest instead of nose as the executable, things should just work.

i'm using the nose api to run the tests within the rgw_multisite_tests task, so i'd have to do something similar with pytest (it looks like there's a pytest.main() for that)

e.g. classes that don't inherit from unittest.TestCase will not work

that's a problem, then. the tests in src/test/rgw/rgw_multi/tests.py are free functions

e.g. classes that don't inherit from unittest.TestCase will not work

that's a problem, then. the tests in src/test/rgw/rgw_multi/tests.py are free functions

maybe not. running those tests on the command line with pytest, it seems to find the test functions just fine. i'll give pytest.main() a try in the rgw_multisite_tests task

@alfredodeza i'm having trouble getting pytest.main() to do what i need here - my main requirement is that it runs tests in an already-imported rgw_multi.tests module, because the rgw_multisite_tests task needs to set up the test environment. it does this and calls rgw_multi.tests.init_multi(realm, user), which sets some global variables that are used by all of the tests

i tried using pytest.main(['--pyargs', tests.__name__]) to do this, but it appears to load a separate module, and the tests fail because those global variables are None

i don't see pytest listed as a dependency either - is that coming from somewhere else?

testing my updated suite on ovh, i got Could not find task 'rgw_multisite_tests', which i'm guessing was due to the import pytest

@cbodley Ah, we don't list pytest as a dependency since it's only been used for unit tests so far. If you have things working with pytest, we can definitely add it as a dependency.

updated pr, now adds pytest dependency

i changed the dependency back to nose. i was able to get it 'working' with pytest, but i couldn't get pytest to print its results to the teuthology log. the nose api gives more control over logging, so i decided to stick with that

py.test "captures" stderr and stdout, and spits them out if there are any failures. If you wish to disable that capturing (done so that test runner output is clean) then there is a flag for that: -s

@alfredodeza i tried passing each of -s, --capture=no, and --capture=sys without success

with help from @alfredodeza, i did make some progressing in getting pytest output into teuthology.log

but in further testing, i realized that the tests themselves depend on nose (for nose.tools, nose.plugins.attrib, nose.plugins.skip), so i don't think there's a way to work around that

can we merge this as is?

ping @zmc

@zmc is on pto this week, If you have run the tests with this change and post the results I can merge.

thanks @vasukulkarni, here's the last successful run of the rgw:multisite suite that uses nose: http://pulpito.ceph.com/cbodley-2017-05-16_10:46:23-rgw:multisite-master---basic-smithi/

the jobs fail with valgrind issues, but the tests themselves pass:

INFO:tasks.rgw_multisite_tests:----------------------------------------------------------------------
INFO:tasks.rgw_multisite_tests:Ran 11 tests in 921.748s
INFO:tasks.rgw_multisite_tests:
INFO:tasks.rgw_multisite_tests:OK