qa/rgw: add multisite suite to configure and run multisite tests#14688
qa/rgw: add multisite suite to configure and run multisite tests#14688cbodley merged 14 commits intoceph:masterfrom
Conversation
347d660 to
d607c7a
Compare
be0fa29 to
a373f41
Compare
4e1684e to
9b588f2
Compare
17c4e13 to
753071a
Compare
| log.info('Removing apache config...') | ||
| for client in clients_to_create_as: | ||
| cluster_name, daemon_type, client_id = teuthology.split_role(client) | ||
| client_with_cluster = '.'.join((cluster_name, daemon_type, client_id)) |
There was a problem hiding this comment.
what would you like to see logged here? just that it's getting the right value for client_with_cluster? here's a snippet from a teuthology.log that shows this in action:
INFO:tasks.rgw.client.0:Stopped
INFO:teuthology.orchestra.run.mira114:Running: 'rm -f /home/ubuntu/cephtest/rgw.opslog.ceph.client.0.sock'
INFO:tasks.rgw:Stopping apache...
INFO:tasks.rgw:Removing apache config...
INFO:teuthology.orchestra.run.mira114:Running: 'rm -f /home/ubuntu/cephtest/apache/apache.ceph.client.0.conf && rm -f /home/ubuntu/cephtest/apache/htdocs.ceph.client.0/rgw.fcgi'
INFO:tasks.rgw:Cleaning up apache directories...
INFO:teuthology.orchestra.run.mira114:Running: 'rm -rf /home/ubuntu/cephtest/apache/tmp.ceph.client.0 && rmdir /home/ubuntu/cephtest/apache/htdocs.ceph.client.0'
INFO:teuthology.orchestra.run.mira114:Running: 'rmdir /home/ubuntu/cephtest/apache'
DEBUG:teuthology.run_tasks:Unwinding manager ceph
There was a problem hiding this comment.
I wanted the cluster name and client id.
I see from the logs the client id is already logged and I can find out what is cluster name from the teuthology node.
No need to add more logging
| # separate region info so only clients are keys in config | ||
| regions = config['regions'] | ||
| del config['regions'] | ||
| regions = config.pop('regions', {}) |
There was a problem hiding this comment.
maybe it is time to change it to zonegroups :)
It can be in a separate pr ...
There was a problem hiding this comment.
yeah, i have a https://github.com/cbodley/ceph/commits/wip-rgw-agent-cleanup branch that removes this stuff
src/test/rgw/rgw_multi/tests.py
Outdated
| return period, realm_epoch, num_shards, markers | ||
|
|
||
| def meta_sync_status(zone): | ||
| for _ in range(60): |
There was a problem hiding this comment.
can you add a comment why 60?
I see it used a few times maybe a const?
There was a problem hiding this comment.
yeah, i just settled on a total of 5 minutes. i'll make this configurable along with the sleep in set_master_zone()
src/test/rgw/rgw_multi/tests.py
Outdated
| zonegroup.master_zone = zone | ||
| # wait for reconfiguration, so that later metadata requests go to the new master | ||
| time.sleep(5) | ||
| time.sleep(15) |
There was a problem hiding this comment.
maybe it should be configurable?
There was a problem hiding this comment.
good idea! then we can keep it at 5 for test_multi.py, and raise it as much as we need to for teuthology
1907d99 to
b18c20a
Compare
also removes unnecessary tuple parens Signed-off-by: Casey Bodley <cbodley@redhat.com>
this makes the 'compression type' setting global to all gateways, and makes the setting visible to other tasks in ctx.rgw.compression_type Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
b18c20a to
b39b314
Compare
Signed-off-by: Casey Bodley <cbodley@redhat.com>
if multisite tests are going to run in teuthology, they can't loop forever Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
changes default level from info to debug Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
b39b314 to
de836ee
Compare
|
the latest run of the full rgw suite with the rgw:multisite suite pretty much always fails with valgrind errors (and osd crashes on shutdown), but the multisite tests themselves are passing:
|
work in progress for a multisite test suite in teuthology
TODO:
rgw.ec_data_poolrgw compression typesetting for created zonesrgw_multisite_teststask to run multisite tests using configuration fromrgw-multisitetasknoseas dependency to teuthology (see rgw: add nose dependency for rgw_multisite_tests task teuthology#1069)