build: notcmalloc builds enable WITH_BOOST_VALGRIND#1736
Merged
Conversation
this flag silences a false-positive from valgrind in boost::context:
```
<error>
<unique>0x0</unique>
<tid>124</tid>
<kind>InvalidRead</kind>
<what>Invalid read of size 8</what>
<stack>
<frame>
<ip>0x52FF7E7</ip>
<obj>/usr/lib64/libradosgw.so.2.0.0</obj>
<fn>spawn::detail::continuation_context::resume()</fn>
</frame>
</stack>
<auxwhat>Address 0x57f65728 is in a rw- anonymous segment</auxwhat>
</error>
```
Fixes: https://tracker.ceph.com/issues/48963
Signed-off-by: Casey Bodley <cbodley@redhat.com>
tchaikov
approved these changes
Feb 3, 2021
Contributor
Author
|
thank you @tchaikov! |
cbodley
added a commit
to cbodley/ceph
that referenced
this pull request
Feb 3, 2021
the WITH_SYSTEM_BOOST binaries are not built with BOOST_USE_VALGRIND, so it probably isn't safe to define for the headers only this flag is needed for teuthology testing, and the shaman builds use WITH_SYSTEM_BOOST=OFF. so the better fix is to enable WITH_BOOST_VALGRIND so BuildBoost.cmake will build the libraries with valgrind support and add -DBOOST_USE_VALGRIND to the necessary targets this change was merged in ceph/ceph-build#1736 Fixes: https://tracker.ceph.com/issues/48963 Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 tasks
Contributor
Author
|
fyi, i'm seeing radosgw segfaults from these builds. hopefully it doesn't affect other targets |
Contributor
Author
|
ok, the segfault is just an issue with the radosgw's cmake. the radosgw target didn't get the |
cbodley
added a commit
to cbodley/ceph
that referenced
this pull request
Feb 12, 2021
the WITH_SYSTEM_BOOST binaries are not built with BOOST_USE_VALGRIND, so it probably isn't safe to define for the headers only this flag is needed for teuthology testing, and the shaman builds use WITH_SYSTEM_BOOST=OFF. so the better fix is to enable WITH_BOOST_VALGRIND so BuildBoost.cmake will build the libraries with valgrind support and add -DBOOST_USE_VALGRIND to the necessary targets this change was merged in ceph/ceph-build#1736 Fixes: https://tracker.ceph.com/issues/48963 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 3c3a651)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this flag silences a false-positive from valgrind in boost::context:
Fixes: https://tracker.ceph.com/issues/48963