cmake/rgw: forward spawn's compile options to rgw_common object library#39279
Merged
cbodley merged 2 commits intoceph:masterfrom Feb 3, 2021
Merged
cmake/rgw: forward spawn's compile options to rgw_common object library#39279cbodley merged 2 commits intoceph:masterfrom
cbodley merged 2 commits intoceph:masterfrom
Conversation
targets that depend on spawn via target_link_libraries() automatically pull in their compile options and include directories Signed-off-by: Casey Bodley <cbodley@redhat.com>
since rgw_common is an OBJECT library, we can't use target_link_libraries() for its dependency on spawn. we add its include directories manually already with $<TARGET_PROPERTY:spawn,INTERFACE_INCLUDE_DIRECTORIES>, but this didn't pull in the compile definitions. this ultimately prevented the WITH_BOOST_VALGRIND option from passing the BOOST_USE_VALGRIND definition attached to boost::context Signed-off-by: Casey Bodley <cbodley@redhat.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since rgw_common is an OBJECT library, we can't use
target_link_libraries()for its dependency on spawn. we add its include directories manually already with$<TARGET_PROPERTY:spawn,INTERFACE_INCLUDE_DIRECTORIES>, but this didn't pull in the compile definitions. this ultimately prevented theWITH_BOOST_VALGRINDoption from passing theBOOST_USE_VALGRINDdefinition attached to boost::contextFixes: https://tracker.ceph.com/issues/48963
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox