mds: use SimpleLock::WAIT_ALL for wait mask#67496
Conversation
|
The |
|
|
jenkins test make check |
|
jenkins test make check arm64 |
The Locker uses has_any_waiter for a particular lock to evaluate whether to nudge the log. For the squid, tentacle, and main branches, this larger bit mask (all 64 bits) will cause this to wrongly return true for other locks which have waiters. The side-effect of waking requests spuriously is undesirable but should not affect performance significantly. For reef and older releases, using std::numeric_limits<uint64_t>::max() in has_any_waiter() causes a bitwise overflow that sets the wait-queue search bound impossibly high, resulting in the method always incorrectly returning false. This results in nudge_log never nudging the log! Fixes: db5c9dc Fixes: https://tracker.ceph.com/issues/75141 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
|
This PR is under test in https://tracker.ceph.com/issues/75334. |
* refs/pull/67496/head: Reviewed-by: Venky Shankar <vshankar@redhat.com>
|
This is an automated message by src/script/redmine-upkeep.py. I have resolved the following tracker ticket due to the merge of this PR: No backports are pending for the ticket. If this is incorrect, please update the tracker Update Log: https://github.com/ceph/ceph/actions/runs/23188475930 |
|
This is an automated message by src/script/redmine-upkeep.py. I found one or more
The referenced tickets are: Those tickets do not reference this merged Pull Request. If this Pull Request merge resolves any of those tickets, please update the "Pull Request ID" field on each ticket. A future run of this script will appropriately update them. Update Log: https://github.com/ceph/ceph/actions/runs/23188475930 |
The Locker uses has_any_waiter for a particular lock to evaluate whether to nudge the log. For the squid, tentacle, and main branches, this larger bit mask (all 64 bits) will cause this to wrongly return true for other locks which have waiters. The side-effect of waking requests spuriously is undesirable but should not affect performance significantly.
For reef and older releases, using std::numeric_limits<uint64_t>::max() in has_any_waiter() causes a bitwise overflow that sets the wait-queue search bound impossibly high, resulting in the method always incorrectly returning false. This results in nudge_log never nudging the log!
Fixes: db5c9dc
Fixes: https://tracker.ceph.com/issues/75141
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.