The Locker uses has_any_waiter for a particular lock to evaluate whether to nudge the log. For the squid, tentacle, and main branches, this larger bit mask (all 64 bits) will cause this to wrongly return true for other locks which have waiters. The side-effect of waking requests spuriously is undesirable but should not affect performance significantly.

For reef and older releases, using std::numeric_limits<uint64_t>::max() in has_any_waiter() causes a bitwise overflow that sets the wait-queue search bound impossibly high, resulting in the method always incorrectly returning false. This results in nudge_log never nudging the log!

Note: for reef the fix is different because of the interface refactor. For that reason, this fix is applied directly to reef.

Fixes: db5c9dc
Fixes: https://tracker.ceph.com/issues/75141

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

• When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests