Skip to content

tentacle: RGW | fix conditional Delete, MultiDelete and Put#65949

Merged
batrick merged 3 commits intoceph:tentaclefrom
cupnes:wip-73090-tentacle
Feb 19, 2026
Merged

tentacle: RGW | fix conditional Delete, MultiDelete and Put#65949
batrick merged 3 commits intoceph:tentaclefrom
cupnes:wip-73090-tentacle

Conversation

@cupnes
Copy link

@cupnes cupnes commented Oct 15, 2025

backport tracker: https://tracker.ceph.com/issues/73090

backport of #63348
parent tracker: https://tracker.ceph.com/issues/68183

This PR was created using ceph-backport.sh version 16.0.0.6848 for branch creation and cherry-picking, followed by manual conflict resolution, push and PR creation.

@cupnes cupnes requested a review from a team as a code owner October 15, 2025 00:38
@github-actions github-actions bot added the rgw label Oct 15, 2025
@github-actions github-actions bot added this to the tentacle milestone Oct 15, 2025
@cupnes
Copy link
Author

cupnes commented Oct 15, 2025

Once this PR is merged, I plan to create a backport PR for issue #73076 as well.

cbodley
cbodley requested changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quoting https://tracker.ceph.com/issues/68183#note-7:

backports need to include followup fix for https://tracker.ceph.com/issues/72517 #64997

please include the cherry-pick of #64997 in this pr

@cupnes cupnes force-pushed the wip-73090-tentacle branch from 9f1bc00 to d73cdd8 Compare October 16, 2025 02:31
@cupnes
Copy link
Author

cupnes commented Oct 16, 2025

@cbodley
I cherry-picked commit 69353cf from PR #64997 and included it in this PR.

@AliMasarweh @cupnes
RGW | fix conditional Delete and MultiDelete
f28f0d9 
size_match supports size 0
checks_preconditions checks for last_modified and size as well
supports versioned object

Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
(cherry picked from commit 55f5b76)
@AliMasarweh @cupnes
RGW | Added debugs in cases where precondition check fails
0f770c2 
Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
(cherry picked from commit b99a47f)
@cupnes cupnes force-pushed the wip-73090-tentacle branch 2 times, most recently from 9d622b8 to 5406a12 Compare October 16, 2025 05:21
@cupnes cupnes requested a review from cbodley October 16, 2025 08:11
@cbodley
Copy link
Contributor

cbodley commented Oct 17, 2025

thanks @cupnes - could you please redo that cherry-pick with the -x option to add the "(cherry picked from commit ...)" line? https://github.com/ceph/ceph/blob/main/SubmittingPatches-backports.rst#cherry-picking-rules

same goes for #65932

@cupnes cupnes force-pushed the wip-73090-tentacle branch from 5406a12 to dc155b6 Compare October 20, 2025 02:46
@cupnes
Copy link
Author

cupnes commented Oct 20, 2025

@cbodley
Sorry, I missed that. I addressed it.

@cupnes cupnes mentioned this pull request Oct 20, 2025
Open
@cupnes cupnes force-pushed the wip-73090-tentacle branch from dc155b6 to a77e7cd Compare October 20, 2025 05:51
cbodley
cbodley approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm @cupnes

@cbodley
Copy link
Contributor

cbodley commented Oct 20, 2025

cc @adamemerson this will need manual qa against ceph/s3-tests#663

@cupnes cupnes force-pushed the wip-73090-tentacle branch 3 times, most recently from 3be6400 to 63f6089 Compare October 22, 2025 00:57
@AliMasarweh @cupnes
RGW | fixed enqueueing the overwritten object for gc
8045fe6 
Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
(cherry picked from commit 69353cf)
@cupnes cupnes force-pushed the wip-73090-tentacle branch from 63f6089 to 8045fe6 Compare October 22, 2025 04:13
@satoru-takeuchi
Copy link
Contributor

satoru-takeuchi commented Feb 6, 2026

@cbodley @adamemerson Is there any chance to merge this PR and the upcoming backport PR corresponding to issue 73300? My team, including @cupnes, are looking forward to these PRs because we uses conditional write with muptile uploads in our Ceph clusters (v19.2.1).

I asked this question since I found that v20.2.1 validation has already been started in the latest CSC minutes.

@cbodley cbodley added the needs-separate-s3tests-qa This is a PR to RGW that, at present, needs to be QA'd against is own s3tests branch before merge. label Feb 6, 2026
@batrick
Copy link
Member

batrick commented Feb 10, 2026

@cbodley @adamemerson Is there any chance to merge this PR and the upcoming backport PR corresponding to issue 73300? My team, including @cupnes, are looking forward to these PRs because we uses conditional write with muptile uploads in our Ceph clusters (v19.2.1).

I asked this question since I found that v20.2.1 validation has already been started in the latest CSC minutes.

@cbodley @adamemerson https://tracker.ceph.com/issues/73300 needs attention.

@cbodley cbodley removed the needs-qa label Feb 11, 2026
@cbodley
Copy link
Contributor

cbodley commented Feb 11, 2026

cc @adamemerson this will need manual qa against ceph/s3-tests#663

thanks @batrick. i removed your needs-qa label because this needs manual qa with its test cases - this is what the needs-separate-s3tests-qa label is for

@cbodley
Copy link
Contributor

cbodley commented Feb 11, 2026

builds pending in https://shaman.ceph.com/builds/ceph/wip-73090-tentacle/

i prepared a suite-branch at https://github.com/cbodley/ceph/commits/wip-qa-73090-tentacle that points at backported test cases in https://github.com/cbodley/s3-tests/commits/wip-73090-tentacle

@cbodley
Copy link
Contributor

cbodley commented Feb 12, 2026

qa pending in https://pulpito.ceph.com/cbodley-2026-02-12_15:40:18-rgw-wip-73090-tentacle-distro-default-trial/

@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented Feb 12, 2026

Can one of the admins verify this patch?

@batrick batrick modified the milestones: tentacle, v20.2.1 Feb 13, 2026
@cbodley
Copy link
Contributor

cbodley commented Feb 17, 2026

qa pending in https://pulpito.ceph.com/cbodley-2026-02-12_15:40:18-rgw-wip-73090-tentacle-distro-default-trial/

rgw/bucket-logging: 1 job failed
test_bucket_logging_object_meta FAILED and then the rest of the tests failed with ERROR, tracked in https://tracker.ceph.com/issues/74322

rgw/dbstore: 1 job failed
new tests failed, needs backport of ceph/s3-tests#689

rgw/multifs: 3 jobs failed
s3_user_quota-run.sh fails to start with https://tracker.ceph.com/issues/74590

rgw/multisite: 2 jobs failed
does not run because of boto2, needs to run with #67318 for https://tracker.ceph.com/issues/74886

rgw/notifications: 4 jobs failed
does not run because of boto2, tracked in https://tracker.ceph.com/issues/74573

rgw/singleton: 3 jobs failed
radosgw_admin and radosgw_admin_rest tasks don't run because of boto2, tracked in https://tracker.ceph.com/issues/74591

rgw/tempest: 1 job failed
spurious test failure tracked in https://tracker.ceph.com/issues/72968

@cbodley
Copy link
Contributor

cbodley commented Feb 17, 2026

rgw/dbstore: 1 job failed
new tests failed, needs backport of ceph/s3-tests#689

updated https://github.com/cbodley/s3-tests/commits/wip-73090-tentacle with that backport. will rerun rgw/dbstore once the lab permits

@cbodley
Copy link
Contributor

cbodley commented Feb 17, 2026

the repos disappeared at https://shaman.ceph.com/repos/ceph/wip-71752-tentacle/ so i'm waiting for fresh builds in https://shaman.ceph.com/builds/ceph/wip-71752-tentacle/420b253ddb979c1dc7c80341bad973ed9a00557c/

@cbodley
Copy link
Contributor

cbodley commented Feb 18, 2026

the repos disappeared at https://shaman.ceph.com/repos/ceph/wip-71752-tentacle/ so i'm waiting for fresh builds in https://shaman.ceph.com/builds/ceph/wip-71752-tentacle/420b253ddb979c1dc7c80341bad973ed9a00557c/

dbstore rerun pending in https://pulpito.ceph.com/cbodley-2026-02-18_15:17:32-rgw-wip-73090-tentacle-distro-default-smithi/

@batrick
Copy link
Member

batrick commented Feb 19, 2026

the repos disappeared at https://shaman.ceph.com/repos/ceph/wip-71752-tentacle/ so i'm waiting for fresh builds in https://shaman.ceph.com/builds/ceph/wip-71752-tentacle/420b253ddb979c1dc7c80341bad973ed9a00557c/

dbstore rerun pending in https://pulpito.ceph.com/cbodley-2026-02-18_15:17:32-rgw-wip-73090-tentacle-distro-default-smithi/

@cbodley you scheduled on smithi

@cbodley
Copy link
Contributor

cbodley commented Feb 19, 2026

@cbodley you scheduled on smithi

thanks, no wonder it was stuck in the queue. rescheduled https://pulpito.ceph.com/cbodley-2026-02-19_13:59:31-rgw-wip-73090-tentacle-distro-default-trial/

@cbodley
Copy link
Contributor

cbodley commented Feb 19, 2026

dbstore rerun passed 👍 so despite some missing coverage in other subsuites, all of the test cases for this feature are green

@batrick batrick merged commit c824a7f into ceph:tentacle Feb 19, 2026
11 checks passed
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

This is an automated message by src/script/redmine-upkeep.py.

I have resolved the following tracker ticket due to the merge of this PR:

No backports are pending for the ticket. If this is incorrect, please update the tracker
ticket and reset to Pending Backport state.

Update Log: https://github.com/ceph/ceph/actions/runs/22192060092

@cbodley
Copy link
Contributor

cbodley commented Feb 19, 2026

i've pushed the backported test cases to https://github.com/ceph/s3-tests/commits/ceph-tentacle so they're part of the default rgw suite on tentacle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley approved these changes

Assignees

No one assigned

Labels

needs-separate-s3tests-qa This is a PR to RGW that, at present, needs to be QA'd against is own s3tests branch before merge. rgw wip-cbodley-testing

Projects

None yet

Milestone

v20.2.1

Development

Successfully merging this pull request may close these issues.

6 participants

@cupnes @cbodley @satoru-takeuchi @batrick @ceph-jenkins @AliMasarweh