Skip to content

squid: RGW | fix conditional Delete, MultiDelete and Put#65932

Open
cupnes wants to merge 3 commits intoceph:squidfrom
cupnes:wip-73089-squid
Open

squid: RGW | fix conditional Delete, MultiDelete and Put#65932
cupnes wants to merge 3 commits intoceph:squidfrom
cupnes:wip-73089-squid

Conversation

@cupnes
Copy link

@cupnes cupnes commented Oct 14, 2025

backport tracker: https://tracker.ceph.com/issues/73089

backport of #63348
parent tracker: https://tracker.ceph.com/issues/68183

This PR was created using ceph-backport.sh version 16.0.0.6848 for branch creation and cherry-picking, followed by manual conflict resolution, push and PR creation.

@cupnes cupnes requested a review from a team as a code owner October 14, 2025 12:00
@github-actions github-actions bot added the rgw label Oct 14, 2025
@github-actions github-actions bot added this to the squid milestone Oct 14, 2025
@cupnes
Copy link
Author

cupnes commented Oct 14, 2025

Once this PR is merged, I plan to create a backport PR for issue #73076 as well.

@cupnes cupnes force-pushed the wip-73089-squid branch 4 times, most recently from d5bf282 to df6e05a Compare October 15, 2025 05:52
cbodley
cbodley requested changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quoting https://tracker.ceph.com/issues/68183#note-7:

backports need to include followup fix for https://tracker.ceph.com/issues/72517 #64997

please include the cherry-pick of #64997 in this pr

@cupnes
Copy link
Author

cupnes commented Oct 16, 2025

@cbodley
I cherry-picked commit 69353cf from PR #64997 and included it in this PR.

@cupnes cupnes requested a review from cbodley October 16, 2025 05:19
@cbodley cbodley mentioned this pull request Oct 17, 2025
Merged
@cupnes
Copy link
Author

cupnes commented Oct 20, 2025

@cbodley
Sorry, I addressed this comment.

@cbodley
Copy link
Contributor

cbodley commented Oct 20, 2025

cc @adamemerson this will need manual qa against ceph/s3-tests#663

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@cupnes cupnes force-pushed the wip-73089-squid branch 9 times, most recently from 34201ad to 19ccfc0 Compare October 30, 2025 08:45
@cupnes cupnes force-pushed the wip-73089-squid branch 2 times, most recently from 43fecaa to a62cf78 Compare October 31, 2025 02:48
@AliMasarweh @cupnes
RGW | fix conditional Delete and MultiDelete
90e3eb7 
size_match supports size 0
checks_preconditions checks for last_modified and size as well
supports versioned object

Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
(cherry picked from commit 55f5b76)
@AliMasarweh @cupnes
RGW | Added debugs in cases where precondition check fails
2fc6144 
Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
(cherry picked from commit b99a47f)
@cupnes cupnes force-pushed the wip-73089-squid branch 3 times, most recently from 16bc3f1 to aa098f0 Compare November 14, 2025 02:00
@AliMasarweh @cupnes
RGW | fixed enqueueing the overwritten object for gc
6336670 
Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
(cherry picked from commit 69353cf)
@batrick batrick modified the milestones: squid, v19.2.4 Mar 18, 2026
@batrick
Copy link
Member

batrick commented Mar 18, 2026

cc @adamemerson this will need manual qa against ceph/s3-tests#663

ping @adamemerson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley approved these changes

Assignees

No one assigned

Labels

needs-qa rgw wip-yuri5-testing

Projects

None yet

Milestone

v19.2.4

Development

Successfully merging this pull request may close these issues.

5 participants

@cupnes @cbodley @batrick @yuriw @AliMasarweh